From: David Miller <davem@davemloft.net>
To: peppe.cavallaro@st.com
Cc: netdev@vger.kernel.org, maxime.coquelin@st.com
Subject: Re: [PATCH (net.git) 0/2] stmmac: review and fix the dwmac-sti glue-logic
Date: Tue, 14 Oct 2014 16:41:17 -0400 (EDT) [thread overview]
Message-ID: <20141014.164117.553206792335727136.davem@davemloft.net> (raw)
In-Reply-To: <1413267176-325-1-git-send-email-peppe.cavallaro@st.com>
From: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Date: Tue, 14 Oct 2014 08:12:54 +0200
> This patch is to review the whole glue logic adopted on STi SoCs that
> was bugged.
> In the old glue-logic there was a lot of confusion when setup the
> retiming especially for STiD127 where, for example, the bits 6 and 7
> (in the GMAC control register) have a different meaning of what is
> used for STiH4xx SoCs. So we cannot adopt the same glue for all these
> SoCs.
> Moreover, GiGa on STiD127 didn't work and, for all the SoCs, the RGMII
> couldn't run when the speed was 10Mbps (because the clock was not properly
> managed).
> Note that the phy clock needs to be provided by the platform as well as
> documented in the related binding file (updated as consequence).
>
> The old code supported too many configurations never adopted and validated.
> This made the code very complex to maintain and debug in case of issues.
>
> The patch simplifies all the configurations as commented in the tables
> inside the file and obviously it has been tested on all the boards
> based on the SoCs mentioned.
>
> With this patch, the dwmac-sti is also ready to support new configurations that
> will be available on next SoC generations.
Series applied.
prev parent reply other threads:[~2014-10-14 20:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 6:12 [PATCH (net.git) 0/2] stmmac: review and fix the dwmac-sti glue-logic Giuseppe Cavallaro
2014-10-14 6:12 ` [PATCH (net.git) 1/2] stmmac: make the STi Layer compatible to STiH407 Giuseppe Cavallaro
2014-10-14 6:12 ` [PATCH (net.git) 2/2] stmmac: dwmac-sti: review the glue-logic for STi4xx and STiD127 SoCs Giuseppe Cavallaro
2014-10-14 20:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141014.164117.553206792335727136.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=maxime.coquelin@st.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox