From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net-next,v2] hyperv: Add handling of IP header with option field in netvsc_set_hash() Date: Tue, 14 Oct 2014 22:05:05 -0400 (EDT) Message-ID: <20141014.220505.586366171329066629.davem@davemloft.net> References: <1413317117-28678-1-git-send-email-haiyangz@microsoft.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: olaf@aepfle.de, netdev@vger.kernel.org, jasowang@redhat.com, driverdev-devel@linuxdriverproject.org, linux-kernel@vger.kernel.org To: haiyangz@microsoft.com Return-path: In-Reply-To: <1413317117-28678-1-git-send-email-haiyangz@microsoft.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" List-Id: netdev.vger.kernel.org From: Haiyang Zhang Date: Tue, 14 Oct 2014 20:05:17 +0000 > In case that the IP header has optional field at the end, this patch will > get the port numbers after that field, and compute the hash. > > Signed-off-by: Haiyang Zhang > Reviewed-by: K. Y. Srinivasan This isn't even close to what I asked for. I said to remove all of this by-hand header parsing code in the hyperv driver, and use the generic code networking facilities that exist already to do this.