From: Richard Cochran <richardcochran@gmail.com>
To: "Frank.Li@freescale.com" <Frank.Li@freescale.com>
Cc: David Miller <davem@davemloft.net>,
"fugang.duan@freescale.com" <fugang.duan@freescale.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"bhutchings@solarflare.com" <bhutchings@solarflare.com>
Subject: Re: [PATCH] net: fec: ptp: fix convergence issue to support LinuxPTP stack
Date: Tue, 14 Oct 2014 20:49:52 +0200 [thread overview]
Message-ID: <20141014184952.GC14216@localhost.localdomain> (raw)
In-Reply-To: <6b1256b73b7a4f978573a77ec3e36831@BLUPR03MB486.namprd03.prod.outlook.com>
On Tue, Oct 14, 2014 at 06:43:51PM +0000, Frank.Li@freescale.com wrote:
> Only MX6 SX. Only MX6 SX added FEC_QUIRK_BUG_CAPTURE.
But what about this comment:
+/* ENET Block Guide/ Chapter for the iMX6SLX (PELE) address one issue:
+ * Incorrect behavior for ENET_ATCR[Capture and Restart Bits]. These bits will
+ * always read a value zero. When these bits are set to 1'b1, these should hold
+ * value 1'b1 until the counter value is capture in the register clock domain.
+ */
It sounds like the bits are "sticky" until the counter value has been
latched. Therefore you need to check the bits before reading the
counter, but the code does not do this for the case of !SX.
Thanks,
Richard
next prev parent reply other threads:[~2014-10-14 18:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 5:39 [PATCH] net: fec: ptp: fix convergence issue to support LinuxPTP stack Fugang Duan
2014-10-14 10:36 ` Richard Cochran
2014-10-14 16:52 ` David Miller
2014-10-14 18:27 ` Frank.Li
2014-10-14 18:39 ` Richard Cochran
2014-10-14 18:43 ` Frank.Li
2014-10-14 18:49 ` Richard Cochran [this message]
2014-10-15 1:28 ` fugang.duan
2014-10-15 1:37 ` fugang.duan
2014-10-15 1:30 ` fugang.duan
2014-10-15 7:25 ` Richard Cochran
2014-10-15 7:42 ` fugang.duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141014184952.GC14216@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=Frank.Li@freescale.com \
--cc=bhutchings@solarflare.com \
--cc=davem@davemloft.net \
--cc=fugang.duan@freescale.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).