Re: [PATCH RFC v4 net 1/3] ipv6: Remove BACKTRACK macro

[Martin Lau <kafai@fb.com>]

Hi,

> > +struct fib6_node *fib6_backtrack(struct fib6_node *fn,
> > +				 struct in6_addr *saddr);
> > +
> 
> I am completely mystified why you did this, could you explain the
> logic?  I want to know what drove you to make this exported.
>
> I marked it static in my example patch, and there is no caller outside
> of route.c
> 

I was thinking this function only works on 'struct fib6_node', so
it belongs to ip6_fib.c more than route.c.
f.e. like fib6_lookup() whose callers are also only in route.c

> Doing this also eliminates inlining opportunitites.
> 
> Please keep this private inside of route.c
I will keep it private in route.c and re-submit.

Do you have input on the function signature and also the following two
patches?

Thanks,
--Martin