From: Willy Tarreau <w@1wt.eu>
To: Zhu Yanjun <zyjzyj2000@gmail.com>
Cc: sandeep.kumar@freescale.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Yue.Tao@windriver.com,
guang.yang@windriver.com, joe@perches.com, festevam@gmail.com,
richardcochran@gmail.com, clarocq@gmail.com,
yongjun_wei@trendmicro.com.cn, claudiu.manoil@freescale.com,
roy.xu@huawei.com, sky.wangfeng@huawei.com,
Zhu Yanjun <Yanjun.Zhu@windriver.com>
Subject: Re: [PATCH] gianfar: disable vlan tag insertion by default on 2.6.x
Date: Wed, 15 Oct 2014 12:09:49 +0200 [thread overview]
Message-ID: <20141015100949.GA30089@1wt.eu> (raw)
In-Reply-To: <1413367234-28652-1-git-send-email-Yanjun.Zhu@windriver.com>
Hi Zhu,
On Wed, Oct 15, 2014 at 06:00:33PM +0800, Zhu Yanjun wrote:
> In commit f43c75d4b6[gianfar: disable TX vlan based on kernel 2.6.x],
> gianfar nic disables TX vlan. But gianfar nic enables vlan tag
> insertion by default. This will lead to unusable connections on
> some configurations. Since vlan tag insertion is disabled by default
> and it is not enabled any longer, it is not necessary to disable it again.
>
> Zhu Yanjun (1):
> gianfar: disable vlan tag insertion by default
>
> drivers/net/gianfar.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> --
> 1.9.1
There's no patch in this e-mail. Since you sent another e-mail with almost
the same subject, I'm confused, it's unclear to me whether I only need to
apply the patch in the other one with this commit message or if it's just
that you accidently dropped the patch when sending this e-mail. Could you
please enlighten me ?
Thanks,
Willy
next prev parent reply other threads:[~2014-10-15 10:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 10:00 [PATCH] gianfar: disable vlan tag insertion by default on 2.6.x Zhu Yanjun
2014-10-15 10:00 ` [PATCH] gianfar: disable vlan tag insertion by default Zhu Yanjun
2014-10-15 10:09 ` Willy Tarreau [this message]
2014-10-15 10:15 ` [PATCH] gianfar: disable vlan tag insertion by default on 2.6.x yzhu1
2014-10-15 10:22 ` zhuyj
2014-10-15 12:01 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141015100949.GA30089@1wt.eu \
--to=w@1wt.eu \
--cc=Yanjun.Zhu@windriver.com \
--cc=Yue.Tao@windriver.com \
--cc=clarocq@gmail.com \
--cc=claudiu.manoil@freescale.com \
--cc=festevam@gmail.com \
--cc=guang.yang@windriver.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=roy.xu@huawei.com \
--cc=sandeep.kumar@freescale.com \
--cc=sky.wangfeng@huawei.com \
--cc=yongjun_wei@trendmicro.com.cn \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).