From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [RFC PATCH net-next 6/6] virtio-net: enable tx interrupt only for the final skb in the chain Date: Wed, 15 Oct 2014 13:46:42 +0300 Message-ID: <20141015104642.GJ25776@redhat.com> References: <1413357930-45302-1-git-send-email-jasowang@redhat.com> <1413357930-45302-7-git-send-email-jasowang@redhat.com> <20141015102251.GE25776@redhat.com> <543E4CF7.1040405@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: eric.dumazet@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, davem@davemloft.net To: Jason Wang Return-path: Content-Disposition: inline In-Reply-To: <543E4CF7.1040405@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: netdev.vger.kernel.org On Wed, Oct 15, 2014 at 06:31:19PM +0800, Jason Wang wrote: > On 10/15/2014 06:22 PM, Michael S. Tsirkin wrote: > > On Wed, Oct 15, 2014 at 03:25:30PM +0800, Jason Wang wrote: > >> With the help of xmit_more and virtqueue_enable_cb_avail(), this patch > >> enable tx interrupt only for the final skb in the chain if > >> needed. This will help to mitigate tx interrupts. > >> > >> Cc: Rusty Russell > >> Cc: Michael S. Tsirkin > >> Signed-off-by: Jason Wang > > I think you should split xmit_more stuff out. > > No much difference but if you prefer I will do this. In fact I did it exactly like this already :) -- MST