From: David Miller <davem@davemloft.net>
To: imorgan@primordial.ca
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net] ax88179_178a: fix bonding failure
Date: Mon, 20 Oct 2014 00:55:26 -0400 (EDT) [thread overview]
Message-ID: <20141020.005526.1789570582328212500.davem@davemloft.net> (raw)
In-Reply-To: <alpine.LFD.2.11.1410190801050.5282@solo.int.primordial.ca>
From: Ian Morgan <imorgan@primordial.ca>
Date: Sun, 19 Oct 2014 08:05:13 -0400 (EDT)
> The following patch fixes a bug which causes the ax88179_178a driver to be
> incapable of being added to a bond.
>
> When I brought up the issue with the bonding maintainers, they indicated
> that the real problem was with the NIC driver which must return zero for
> success (of setting the MAC address). I see that several other NIC drivers
> follow that pattern by either simply always returing zero, or by passing
> through a negative (error) result while rewriting any positive return code
> to zero. With that same philisophy applied to the ax88179_178a driver, it
> allows it to work correctly with the bonding driver.
>
> I believe this is suitable for queuing in -stable, as it's a small, simple,
> and obvious fix that corrects a defect with no other known workaround.
>
> This patch is against vanilla 3.17(.0).
>
> Signed-off-by: Ian Morgan <imorgan@primordial.ca>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2014-10-20 4:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-19 12:05 [PATCH net] ax88179_178a: fix bonding failure Ian Morgan
2014-10-20 4:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141020.005526.1789570582328212500.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=imorgan@primordial.ca \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).