From: David Miller <davem@davemloft.net>
To: roy.qing.li@gmail.com
Cc: netdev@vger.kernel.org, steffen.klassert@secunet.com
Subject: Re: [PATCH 1/2] xfrm: fix a potential use after free in xfrm4_policy.c
Date: Tue, 21 Oct 2014 21:42:52 -0400 (EDT) [thread overview]
Message-ID: <20141021.214252.1991608537444325198.davem@davemloft.net> (raw)
In-Reply-To: <1413794954-16967-1-git-send-email-roy.qing.li@gmail.com>
From: roy.qing.li@gmail.com
Date: Mon, 20 Oct 2014 16:49:13 +0800
> From: Li RongQing <roy.qing.li@gmail.com>
>
> pskb_may_pull() maybe change skb->data and make xprth pointer oboslete,
> so recompute the xprth
>
> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
Please don't use macros that hide uses of local variables.
That is almost as bad as hiding control flow inside of
a macro.
prev parent reply other threads:[~2014-10-22 1:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-20 8:49 [PATCH 1/2] xfrm: fix a potential use after free in xfrm4_policy.c roy.qing.li
2014-10-20 8:49 ` [PATCH 2/2] xfrm6: fix a potential use after free in xfrm6_policy.c roy.qing.li
2014-10-20 10:36 ` Sergei Shtylyov
2014-10-22 1:42 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141021.214252.1991608537444325198.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roy.qing.li@gmail.com \
--cc=steffen.klassert@secunet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).