From: Thomas Graf <tgraf@noironetworks.com>
To: Simon Horman <simon.horman@netronome.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Pravin Shelar <pshelar@nicira.com>,
dev@openvswitch.org
Subject: Re: [ovs-dev] [PATCH net-next] datapath: Rename last_action() as nla_is_last() and move to netlink.h
Date: Mon, 27 Oct 2014 11:08:26 +0100 [thread overview]
Message-ID: <20141027100826.GA25339@pox.localdomain> (raw)
In-Reply-To: <1414393936-14463-1-git-send-email-simon.horman@netronome.com>
On 10/27/14 at 04:12pm, Simon Horman wrote:
> The original motivation for this change was to allow the helper to be used
> in files other than actions.c as part of work on an odp select group
> action.
>
> It was as pointed out by Thomas Graf that this helper would be best off
> living in netlink.h. Furthermore, I think that the generic nature of this
> helper means it is best off in netlink.h regardless of if it is used more
> than one .c file or not. Thus, I would like it considered independent of
> the work on an odp select group action.
>
> Cc: Thomas Graf <tgraf@suug.ch>
> Cc: Pravin Shelar <pshelar@nicira.com>
> Cc: Andy Zhou <azhou@nicira.com>
> Signed-off-by: Simon Horman <simon.horman@netronome.com>
Acked-by: Thomas Graf <tgraf@noironetworks.com>
next prev parent reply other threads:[~2014-10-27 10:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 7:12 [PATCH net-next] datapath: Rename last_action() as nla_is_last() and move to netlink.h Simon Horman
2014-10-27 10:08 ` Thomas Graf [this message]
2014-10-28 21:08 ` David Miller
2014-10-29 2:10 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141027100826.GA25339@pox.localdomain \
--to=tgraf@noironetworks.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=simon.horman@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).