From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH net 0/3] cdc-ether: handle promiscuous mode Date: Tue, 28 Oct 2014 17:30:32 -0400 (EDT) Message-ID: <20141028.173032.834085511529381633.davem@davemloft.net> References: <1414172582-30844-1-git-send-email-olivier.blin@softathome.com> <20141028.154926.273240718595756465.davem@davemloft.net> <1414530625.29018.1.camel@linux-0dmf.site> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: olivier.blin@softathome.com, netdev@vger.kernel.org, hayeswang@realtek.com, bjorn@mork.no To: oneukum@suse.de Return-path: Received: from shards.monkeyblade.net ([149.20.54.216]:36196 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932065AbaJ1Vae (ORCPT ); Tue, 28 Oct 2014 17:30:34 -0400 In-Reply-To: <1414530625.29018.1.camel@linux-0dmf.site> Sender: netdev-owner@vger.kernel.org List-ID: From: Oliver Neukum Date: Tue, 28 Oct 2014 22:10:25 +0100 > On Tue, 2014-10-28 at 15:49 -0400, David Miller wrote: >> From: Olivier Blin >> Date: Fri, 24 Oct 2014 19:42:59 +0200 >> >> > Since kernel 3.16, my Lenovo USB network adapters (RTL8153) using >> > cdc-ether are not working anymore in a bridge. >> > >> > This is due to commit c472ab68ad67db23c9907a27649b7dc0899b61f9, which >> > resets the packet filter when the device is bound. >> > >> > The default packet filter set by cdc-ether does not include >> > promiscuous, while the adapter seemed to have promiscuous enabled by >> > default. >> > >> > This patch series allows to support promiscuous mode for cdc-ether, by >> > hooking into set_rx_mode. >> > >> > Incidentally, maybe this device should be handled by the r8152 driver, >> > but this patch series is still nice for other adapters. >> >> Can a usbnet expert please review this series? > > Acked-by: Oliver Neukum Series applied, thanks!