netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Michele Baldessari <michele@acksyn.org>
To: David Miller <davem@davemloft.net>
Cc: linux-sctp@vger.kernel.org, vyasevich@gmail.com,
	nhorman@tuxdriver.com, netdev@vger.kernel.org,
	dborkman@redhat.com
Subject: Re: [net 1/2] sctp: add transport state in /proc/net/sctp/remaddr
Date: Tue, 28 Oct 2014 08:20:40 +0100	[thread overview]
Message-ID: <20141028072040.GA6825@marquez.int.rhx> (raw)
In-Reply-To: <20141027.185545.551457974536550723.davem@davemloft.net>

Hi David,

On Mon, Oct 27, 2014 at 06:55:45PM -0400, David Miller wrote:
> From: Michele Baldessari <michele@acksyn.org>
> Date: Thu, 23 Oct 2014 21:48:40 +0200
> 
> > It is often quite helpful to be able to know the state of a transport
> > outside of the application itself (for troubleshooting purposes or for
> > monitoring purposes). Add it under /proc/net/sctp/remaddr.
> > 
> > Signed-off-by: Michele Baldessari <michele@acksyn.org>
> 
> You can't change the layout of procfs files, applications parse
> these files and any modification can potentially break such tools.

Thanks for the review. I assumed that extending a procfile by adding
a column at the end is ok and that tools must cope with that anyway.
(i.e. like it's been done in f19c29e3e391a66a273e9afebaf01917245148cd)

> Secondly, even if this change were acceptable, targetting this
> change at anything other than the net-next tree is not appropriate
> because it is a new feature.

Ok. Unless you are against adding a column, I'll resubmit to net-next
later this week.

Thanks,
Michele
-- 
Michele Baldessari            <michele@acksyn.org>
C2A5 9DA3 9961 4FFB E01B  D0BC DDD4 DCCB 7515 5C6D

  reply	other threads:[~2014-10-28  7:20 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-23 19:48 [net 1/2] sctp: add transport state in /proc/net/sctp/remaddr Michele Baldessari
2014-10-23 19:48 ` [net 2/2] sctp: replace seq_printf with seq_puts Michele Baldessari
2014-10-23 20:52   ` Neil Horman
2014-10-23 20:51 ` [net 1/2] sctp: add transport state in /proc/net/sctp/remaddr Neil Horman
2014-10-27 22:55 ` David Miller
2014-10-28  7:20   ` Michele Baldessari [this message]
2014-10-28 10:27   ` Neil Horman
2014-10-29 19:18     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141028072040.GA6825@marquez.int.rhx \
    --to=michele@acksyn.org \
    --cc=davem@davemloft.net \
    --cc=dborkman@redhat.com \
    --cc=linux-sctp@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    --cc=vyasevich@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).