From: David Miller <davem@davemloft.net>
To: matei.pavaluca@freescale.com
Cc: netdev@vger.kernel.org, claudiu.manoil@freescale.com
Subject: Re: [PATCH net-next v2 3/3] gianfar: Implement PAUSE frame generation support
Date: Wed, 29 Oct 2014 14:34:18 -0400 (EDT) [thread overview]
Message-ID: <20141029.143418.274385566081130545.davem@davemloft.net> (raw)
In-Reply-To: <1414399364-22308-3-git-send-email-matei.pavaluca@freescale.com>
From: Matei Pavaluca <matei.pavaluca@freescale.com>
Date: Mon, 27 Oct 2014 10:42:44 +0200
> The hardware can automatically generate pause frames when the number
> of free buffers drops under a certain threshold, but in order to do this,
> the address of the last free buffer needs to be written to a specific
> register for each RX queue.
>
> This has to be done in 'gfar_clean_rx_ring' which is called for each
> RX queue. In order not to impact performance, by adding a register write
> for each incoming packet, this operation is done only when the PAUSE frame
> transmission is enabled.
>
> Whenever the link is readjusted, this capability is turned on or off.
>
> Signed-off-by: Matei Pavaluca <matei.pavaluca@freescale.com>
Applied.
But I would turn pause frames on by default, and deal with the
"performance" issue by aggregating the register writes. Only
do it every N cleaned frames.
next prev parent reply other threads:[~2014-10-29 18:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 8:42 [PATCH net-next v2 1/3] Add flow control support flags to gianfar's capabilities Matei Pavaluca
2014-10-27 8:42 ` [PATCH net-next v2 2/3] Fix the way the local advertising flow options are determined Matei Pavaluca
2014-10-29 18:33 ` David Miller
2014-10-27 8:42 ` [PATCH net-next v2 3/3] gianfar: Implement PAUSE frame generation support Matei Pavaluca
2014-10-29 18:34 ` David Miller [this message]
2014-10-29 18:33 ` [PATCH net-next v2 1/3] Add flow control support flags to gianfar's capabilities David Miller
-- strict thread matches above, loose matches on Subject: below --
2014-10-23 9:18 [PATCH net-next v2 3/3] gianfar: Implement PAUSE frame generation support Matei Pavaluca
2014-10-23 9:36 ` Claudiu Manoil
2014-10-23 19:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141029.143418.274385566081130545.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=claudiu.manoil@freescale.com \
--cc=matei.pavaluca@freescale.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).