From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH 1/2] xen-netback: Disable NAPI after disabling interrupts Date: Wed, 29 Oct 2014 11:05:02 +0000 Message-ID: <20141029110502.GD23982@zion.uk.xensource.com> References: <1414510171-12853-1-git-send-email-david.vrabel@citrix.com> <1414510171-12853-2-git-send-email-david.vrabel@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: , , Ian Campbell , Wei Liu , Zoltan Kiss To: David Vrabel Return-path: Received: from smtp02.citrix.com ([66.165.176.63]:44835 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932259AbaJ2LFD (ORCPT ); Wed, 29 Oct 2014 07:05:03 -0400 Content-Disposition: inline In-Reply-To: <1414510171-12853-2-git-send-email-david.vrabel@citrix.com> Sender: netdev-owner@vger.kernel.org List-ID: On Tue, Oct 28, 2014 at 03:29:30PM +0000, David Vrabel wrote: > From: Zoltan Kiss > > Otherwise the interrupt handler still calls napi_complete. Although it > won't schedule NAPI again as either NAPI_STATE_DISABLE or > NAPI_STATE_SCHED is set, it is just unnecessary, and it makes more > sense to do this way. > > Signed-off-by: Zoltan Kiss > Signed-off-by: David Vrabel Acked-by: Wei Liu > --- > drivers/net/xen-netback/interface.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c > index 895fe84..a6a32d3 100644 > --- a/drivers/net/xen-netback/interface.c > +++ b/drivers/net/xen-netback/interface.c > @@ -235,10 +235,10 @@ static void xenvif_down(struct xenvif *vif) > > for (queue_index = 0; queue_index < num_queues; ++queue_index) { > queue = &vif->queues[queue_index]; > - napi_disable(&queue->napi); > disable_irq(queue->tx_irq); > if (queue->tx_irq != queue->rx_irq) > disable_irq(queue->rx_irq); > + napi_disable(&queue->napi); > del_timer_sync(&queue->credit_timeout); > } > } > -- > 1.7.10.4