From: Stephen Hemminger <stephen@networkplumber.org>
To: Christian Hesse <mail@eworm.de>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCHv2 1/1] ip-link: add switch to show human readable output
Date: Wed, 29 Oct 2014 22:47:38 -0700 [thread overview]
Message-ID: <20141029224738.263e27bd@urahara> (raw)
In-Reply-To: <1412980056-7643-1-git-send-email-mail@eworm.de>
On Sat, 11 Oct 2014 00:27:36 +0200
Christian Hesse <mail@eworm.de> wrote:
> Byte and packet count can increase to really big numbers. This adds a
> switch to show human readable output.
>
> % ip -s link ls wl
> 4: wl: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode DORMANT group default qlen 1000
> link/ether 00:de:ad:be:ee:ef brd ff:ff:ff:ff:ff:ff
> RX: bytes packets errors dropped overrun mcast
> 113570876 156975 0 0 0 0
> TX: bytes packets errors dropped carrier collsns
> 27290790 94313 0 0 0 0
> % ip -s -h link ls wl
> 4: wl: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc mq state UP mode DORMANT group default qlen 1000
> link/ether 00:de:ad:be:ee:ef brd ff:ff:ff:ff:ff:ff
> RX: bytes packets errors dropped overrun mcast
> 122368888 169840 0 0 0 0
> 116.7Mi 165.8Ki 0 0 0 0
> TX: bytes packets errors dropped carrier collsns
> 29087507 102309 0 0 0 0
> 27.7Mi 99.9Ki 0 0 0 0
> ---
I like the idea as a concept but there are two issues:
1. The IEC suffix is a rarely used thing and is non-standard
for communications where K = 1000 M = 1000000 etc.
Please just use standard suffices
2. Don't double print the data, if the user asks for human
format, only show the human format.
next prev parent reply other threads:[~2014-10-30 5:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 22:27 [PATCHv2 1/1] ip-link: add switch to show human readable output Christian Hesse
2014-10-30 5:47 ` Stephen Hemminger [this message]
2014-10-30 9:16 ` [PATCH v3 " Christian Hesse
2014-10-31 10:17 ` Christian Hesse
2014-10-31 19:31 ` Stephen Hemminger
2014-10-31 21:33 ` [PATCH v4 " Christian Hesse
2014-11-02 20:51 ` Stephen Hemminger
2014-11-03 6:53 ` Christian Hesse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141029224738.263e27bd@urahara \
--to=stephen@networkplumber.org \
--cc=mail@eworm.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).