From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Horman Subject: Re: [net-next 1/2] sctp: add transport state in /proc/net/sctp/remaddr Date: Thu, 30 Oct 2014 06:24:26 -0400 Message-ID: <20141030102426.GC24783@hmsreliant.think-freely.org> References: <1414661356-17255-1-git-send-email-michele@acksyn.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Vlad Yasevich , linux-sctp@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" To: Michele Baldessari Return-path: Received: from charlotte.tuxdriver.com ([70.61.120.58]:43758 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932852AbaJ3KYg (ORCPT ); Thu, 30 Oct 2014 06:24:36 -0400 Content-Disposition: inline In-Reply-To: <1414661356-17255-1-git-send-email-michele@acksyn.org> Sender: netdev-owner@vger.kernel.org List-ID: On Thu, Oct 30, 2014 at 10:29:15AM +0100, Michele Baldessari wrote: > It is often quite helpful to be able to know the state of a transport > outside of the application itself (for troubleshooting purposes or for > monitoring purposes). Add it under /proc/net/sctp/remaddr. > > Signed-off-by: Michele Baldessari > --- > net/sctp/proc.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/net/sctp/proc.c b/net/sctp/proc.c > index 34229ee7f379..bfb242af06ab 100644 > --- a/net/sctp/proc.c > +++ b/net/sctp/proc.c > @@ -417,7 +417,7 @@ static void *sctp_remaddr_seq_start(struct seq_file *seq, loff_t *pos) > > if (*pos == 0) > seq_printf(seq, "ADDR ASSOC_ID HB_ACT RTO MAX_PATH_RTX " > - "REM_ADDR_RTX START\n"); > + "REM_ADDR_RTX START STATE\n"); > > return (void *)pos; > } > @@ -497,7 +497,13 @@ static int sctp_remaddr_seq_show(struct seq_file *seq, void *v) > * currently implemented, but we can record it with a > * jiffies marker in a subsequent patch > */ > - seq_printf(seq, "0"); > + seq_printf(seq, "0 "); > + > + /* > + * The current state of this destination. I.e. > + * SCTP_ACTIVE, SCTP_INACTIVE, ... > + */ > + seq_printf(seq, "%d", tsp->state); > > seq_printf(seq, "\n"); > } > -- > 2.1.0 > > Acked-by: Neil Horman