From: David Miller <davem@davemloft.net>
To: lsorense@csclub.uwaterloo.ca
Cc: linux-kernel@vger.kernel.org, mugunthanvnm@ti.com,
netdev@vger.kernel.org
Subject: Re: drivers: net: cpsw: Support ALLMULTI and fix IFF_PROMISC in switch mode
Date: Fri, 31 Oct 2014 16:17:17 -0400 (EDT) [thread overview]
Message-ID: <20141031.161717.851599743414417317.davem@davemloft.net> (raw)
In-Reply-To: <20141031173852.GK24110@csclub.uwaterloo.ca>
From: "Lennart Sorensen" <lsorense@csclub.uwaterloo.ca>
Date: Fri, 31 Oct 2014 13:38:52 -0400
> The cpsw driver did not support the IFF_ALLMULTI flag which makes dynamic
> multicast routing not work. Related to this, when enabling IFF_PROMISC
> in switch mode, all registered multicast addresses are flushed, resulting
> in only broadcast and unicast traffic being received.
>
> A new cpsw_ale_set_allmulti function now scans through the ALE entry
> table and adds/removes the host port from the unregistered multicast
> port mask of each vlan entry depending on the state of IFF_ALLMULTI.
> In promiscious mode, cpsw_ale_set_allmulti is used to force reception
> of all multicast traffic in addition to the unicast and broadcast traffic.
>
> With this change dynamic multicast and promiscious mode both work in
> switch mode.
>
> Signed-off-by: Len Sorensen <lsorense@csclub.uwaterloo.ca>
Applied.
prev parent reply other threads:[~2014-10-31 20:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 17:38 drivers: net: cpsw: Support ALLMULTI and fix IFF_PROMISC in switch mode Lennart Sorensen
2014-10-31 20:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141031.161717.851599743414417317.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lsorense@csclub.uwaterloo.ca \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).