From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH] net: ethtool: Return -EOPNOTSUPP if user space tries to read EEPROM with lengh 0 Date: Fri, 31 Oct 2014 04:56:35 +0100 Message-ID: <20141031035635.GC4082@lunn.ch> References: <1414727415-5470-1-git-send-email-linux@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, "David S. Miller" , Andrew Lunn , linux-kernel@vger.kernel.org To: Guenter Roeck Return-path: Content-Disposition: inline In-Reply-To: <1414727415-5470-1-git-send-email-linux@roeck-us.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, Oct 30, 2014 at 08:50:15PM -0700, Guenter Roeck wrote: > If a driver supports reading EEPROM but no EEPROM is installed in the system, > the driver's get_eeprom_len function returns 0. ethtool will subsequently > try to read that zero-length EEPROM anyway. If the driver does not support > EEPROM access at all, this operation will return -EOPNOTSUPP. If the driver > does support EEPROM access but no EEPROM is installed, the operation will > return -EINVAL. Return -EOPNOTSUPP in both cases for consistency. > > Signed-off-by: Guenter Roeck root@dir665:~# ethtool -e lan4 Cannot get EEPROM data: Operation not supported Tested-by: Andrew Lunn Thanks Andrew