Re: [PATCH net 1/2] mpls: Fix mpls_gso handler.

[Simon Horman <simon.horman@netronome.com>]

On Thu, Oct 30, 2014 at 12:49:57AM -0700, Pravin B Shelar wrote:
> mpls gso handler needs to pull skb after segmenting skb.
> 
> CC: Simon Horman <simon.horman@netronome.com>
> Signed-off-by: Pravin B Shelar <pshelar@nicira.com>

Apologies for messing that up, your change does seem to match the comment
above it.

So, assuming that this has been tested:

Acked-by: Simon Horman <simon.horman@netronome.com>

> ---
>  net/mpls/mpls_gso.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/net/mpls/mpls_gso.c b/net/mpls/mpls_gso.c
> index f0f5309..e3545f2 100644
> --- a/net/mpls/mpls_gso.c
> +++ b/net/mpls/mpls_gso.c
> @@ -59,8 +59,7 @@ static struct sk_buff *mpls_gso_segment(struct sk_buff *skb,
>  	 * above pulled.  It will be re-pushed after returning
>  	 * skb_mac_gso_segment(), an indirect caller of this function.
>  	 */
> -	__skb_push(skb, skb->data - skb_mac_header(skb));
> -
> +	__skb_pull(skb, skb->data - skb_mac_header(skb));
>  out:
>  	return segs;
>  }
> -- 
> 1.7.1
>