From: Florian Westphal <fw@strlen.de>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Florian Westphal <fw@strlen.de>, netdev@vger.kernel.org
Subject: Re: [PATCH -next v2 1/2] syncookies: remove ecn_ok validation when decoding option timestamp
Date: Fri, 31 Oct 2014 17:00:39 +0100 [thread overview]
Message-ID: <20141031160039.GM10069@breakpoint.cc> (raw)
In-Reply-To: <1414770460.27538.9.camel@edumazet-glaptop2.roam.corp.google.com>
Eric Dumazet <eric.dumazet@gmail.com> wrote:
> On Fri, 2014-10-31 at 15:15 +0100, Florian Westphal wrote:
>
> > So if you have a per route ecn setting, and syncookies are used,
> > and tcp_ecn sysctl is 0:
>
> This part I do not understand.
>
> Why should tcp_ecn be 0 here, and not 2 (default value) ?
Because admin might have changed it.
There is no problem if tcp_ecn sysctl is nonzero (1 or 2).
This problem will only manifest itself iff tcp_ecn sysctl was set to 0,
and the remote peer requests ecn and a route specific setting enabled
ecn for the source network and syncookies are used.
Current timestamp cookie validation will think "client is lying about
ecn in the timestamp as sysctl is off", since it does not consider a
per-route ecn knob.
next prev parent reply other threads:[~2014-10-31 16:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-31 12:13 [PATCH -next v2 0/2] net: allow setting ecn via routing table Florian Westphal
2014-10-31 12:13 ` [PATCH -next v2 1/2] syncookies: remove ecn_ok validation when decoding option timestamp Florian Westphal
2014-10-31 13:32 ` Eric Dumazet
2014-10-31 13:39 ` Florian Westphal
2014-10-31 14:04 ` Eric Dumazet
2014-10-31 14:15 ` Florian Westphal
2014-10-31 15:47 ` Eric Dumazet
2014-10-31 16:00 ` Florian Westphal [this message]
2014-10-31 12:13 ` [PATCH -next v2 2/2] net: allow setting ecn via routing table Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141031160039.GM10069@breakpoint.cc \
--to=fw@strlen.de \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).