netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: thomas.petazzoni@free-electrons.com
Cc: ezequiel.garcia@free-electrons.com, netdev@vger.kernel.org,
	gregory.clement@free-electrons.com, tawfik@marvell.com,
	alior@marvell.com, nadavh@marvell.com
Subject: Re: [PATCH 1/1] net: mv643xx_eth: Make TSO disabled by default
Date: Sat, 01 Nov 2014 13:40:40 -0400 (EDT)	[thread overview]
Message-ID: <20141101.134040.2199591301326553094.davem@davemloft.net> (raw)
In-Reply-To: <20141101180037.087b7a95@free-electrons.com>

From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Date: Sat, 1 Nov 2014 18:00:37 +0100

> Dear Ezequiel Garcia,
> 
> On Sat,  1 Nov 2014 12:30:20 -0300, Ezequiel Garcia wrote:
>> Data corruption has been observed to be produced by TSO. For instance,
>> accessing files on a NFS-server with TSO enabled results in different data
>> transferred each time.
>> 
>> This has been observed only on Kirkwood platforms, i.e. with the mv643xx_eth
>> driver. Same tests on platforms using the mvneta ethernet driver have
>> passed without errors.
>> 
>> Make TSO disabled by default for now, until we can found a proper fix
>> for the regression.
>> 
>> Fixes: 3ae8f4e0b98 ('net: mv643xx_eth: Implement software TSO')
>> Reported-by: Slawomir Gajzner <slawomir.gajzner@gmail.com>
>> Reported-by: Julien D'Ascenzio <jdascenzio@yahoo.fr>
>> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> 
> Shouldn't you have a:
> 
>    Cc: <stable@vger.kernel.org> # v3.16+

Networking patches do not get sent to -stable that way.

Instead, people specifically request that I queue up the change
for -stable and I submit it by hand at the appropriate time.

  reply	other threads:[~2014-11-01 17:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-01 15:30 [PATCH 0/1] mv643xx_eth: Disable TSO by default Ezequiel Garcia
2014-11-01 15:30 ` [PATCH 1/1] net: mv643xx_eth: Make TSO disabled " Ezequiel Garcia
2014-11-01 17:00   ` Thomas Petazzoni
2014-11-01 17:40     ` David Miller [this message]
2014-11-01 17:26 ` [PATCH 0/1] mv643xx_eth: Disable TSO " Eric Dumazet
2014-11-01 17:33   ` Thomas Petazzoni
2014-11-01 18:01     ` Eric Dumazet
2014-11-01 17:37   ` Eric Dumazet
2014-11-01 19:05     ` Ezequiel Garcia
2014-11-01 17:42   ` David Miller
2014-11-03 14:51   ` David Laight
2014-11-03 19:04     ` Eric Dumazet
2014-11-04 14:20 ` Karl Beldan
2014-11-05  8:39   ` Bug#764162: " Ian Campbell
2014-11-05 10:09     ` Karl Beldan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141101.134040.2199591301326553094.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=alior@marvell.com \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=gregory.clement@free-electrons.com \
    --cc=nadavh@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=tawfik@marvell.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).