From: Stephen Hemminger <shemming@brocade.com>
To: Alexey Andriyanov <alan@al-an.info>
Cc: <netdev@vger.kernel.org>
Subject: Re: [PATCH] iproute2: ip6_tunnel mode bugfixes: any,vti6
Date: Sun, 2 Nov 2014 11:49:17 -0800 [thread overview]
Message-ID: <20141102114917.5529d99a@urahara> (raw)
In-Reply-To: <1414563570-9858-1-git-send-email-alan@al-an.info>
On Wed, 29 Oct 2014 09:19:30 +0300
"Alexey Andriyanov" <alan@al-an.info> wrote:
> - any ipv6 tunnel mode (proto == 0) could not be set
> due to incomplete set of cases in do_add, do_del.
> - vti6 logic was inverted: it was using "ip6_vti0" basedev
> UNLESS mode is set to vti6.
>
> We don't need a switch by p.proto in do_add()/do_del(): it
> already exists in parse_args(). So if parse_args() call
> was successful, no need to check tunnel mode again.
>
> CC: Stephen Hemminger <shemming@brocade.com>
> Signed-off-by: Alexey Andriyanov <alan@al-an.info>
Accepted
prev parent reply other threads:[~2014-11-02 20:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-29 6:19 [PATCH] iproute2: ip6_tunnel mode bugfixes: any,vti6 Alexey Andriyanov
2014-11-02 19:49 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141102114917.5529d99a@urahara \
--to=shemming@brocade.com \
--cc=alan@al-an.info \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox