From: David Miller <davem@davemloft.net>
To: therbert@google.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 3/7] gue: Add infrastructure for flags and options
Date: Mon, 03 Nov 2014 12:18:56 -0500 (EST) [thread overview]
Message-ID: <20141103.121856.1307429117331581815.davem@davemloft.net> (raw)
In-Reply-To: <1414882683-25484-4-git-send-email-therbert@google.com>
From: Tom Herbert <therbert@google.com>
Date: Sat, 1 Nov 2014 15:57:59 -0700
> @@ -20,7 +20,16 @@ static size_t fou_encap_hlen(struct ip_tunnel_encap *e)
>
> static size_t gue_encap_hlen(struct ip_tunnel_encap *e)
> {
> - return sizeof(struct udphdr) + sizeof(struct guehdr);
> + size_t len;
> + bool need_priv = false;
> +
> + len = sizeof(struct udphdr) + sizeof(struct guehdr);
> +
> + /* Add in lengths flags */
> +
> + len += need_priv ? GUE_LEN_PRIV : 0;
Add this need_priv logic in patch #6, not here.
next prev parent reply other threads:[~2014-11-03 17:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-01 22:57 [PATCH net-next 0/7] gue: Remote checksum offload Tom Herbert
2014-11-01 22:57 ` [PATCH net-next 1/7] net: Move fou_build_header into fou.c and refactor Tom Herbert
2014-11-01 22:57 ` [PATCH net-next 2/7] udp: Offload outer UDP tunnel csum if available Tom Herbert
2014-11-01 22:57 ` [PATCH net-next 3/7] gue: Add infrastructure for flags and options Tom Herbert
2014-11-03 17:18 ` David Miller [this message]
2014-11-03 18:39 ` Tom Herbert
2014-11-03 20:12 ` David Miller
2014-11-01 22:58 ` [PATCH net-next 4/7] udp: Changes to udp_offload to support remote checksum offload Tom Herbert
2014-11-01 22:58 ` [PATCH net-next 5/7] gue: Protocol constants for " Tom Herbert
2014-11-01 22:58 ` [PATCH net-next 6/7] gue: TX support for using remote checksum offload option Tom Herbert
2014-11-01 22:58 ` [PATCH net-next 7/7] gue: Receive side of remote checksum offload Tom Herbert
2014-11-03 21:26 ` [PATCH net-next 0/7] gue: Remote " Jesse Gross
2014-11-03 22:39 ` Tom Herbert
2014-11-04 0:19 ` Jesse Gross
2014-11-04 0:59 ` Tom Herbert
2014-11-04 17:33 ` Jesse Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103.121856.1307429117331581815.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).