From: David Miller <davem@davemloft.net>
To: torvalds@linux-foundation.org
Cc: mlg.hessigheim@gmail.com, devel@libdivecomputer.org,
netdev@vger.kernel.org
Subject: Re: Connection with Smart Z hangs
Date: Mon, 03 Nov 2014 12:32:49 -0500 (EST) [thread overview]
Message-ID: <20141103.123249.877120069157206947.davem@davemloft.net> (raw)
In-Reply-To: <CA+55aFzB+d8+pjvuPo-n5G7X9MK9vh9ER5zYLCXZBzjMD4bseA@mail.gmail.com>
From: Linus Torvalds <torvalds@linux-foundation.org>
Date: Sun, 2 Nov 2014 10:20:22 -0800
> David, I'm just going to remove that whole bogus disconnect call. It
> won't make things *work* for Martin (because this is all in the
> "connect failed" path), but that call as-is is just wrong, wrong,
> wrong. And apparently nobody cares about irda any more.
I totally agree, just kill it. For the record this got added in:
commit 5b40964eadea40509d353318d2c82e8b7bf5e8a5
Author: Samuel Ortiz <samuel@sortiz.org>
Date: Mon Oct 11 00:46:51 2010 +0200
irda: Remove BKL instances from af_irda.c
which claims to be just a locking change, but obviously added
this bogus ->disconnect() call as well.
> If anybody is at all interested in helping maintain irda code, holler
> to David and to the netdev mailing list. The position is up for grabs.
Seriously... :-)
prev parent reply other threads:[~2014-11-03 17:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <544782AF.2060406@gmx.de>
[not found] ` <544D4DBB.9050103@libdivecomputer.org>
[not found] ` <54566950.5080206@gmail.com>
2014-11-02 18:20 ` Connection with Smart Z hangs Linus Torvalds
2014-11-03 17:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103.123249.877120069157206947.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=devel@libdivecomputer.org \
--cc=mlg.hessigheim@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).