From: David Miller <davem@davemloft.net>
To: duanj.fnst@cn.fujitsu.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] ipv6: do xfrm transform after nat if necessary
Date: Mon, 03 Nov 2014 14:42:34 -0500 (EST) [thread overview]
Message-ID: <20141103.144234.1037182010018495486.davem@davemloft.net> (raw)
In-Reply-To: <54570A2F.2070206@cn.fujitsu.com>
From: Duan Jiong <duanj.fnst@cn.fujitsu.com>
Date: Mon, 3 Nov 2014 12:53:03 +0800
>
>
> In function nf_nat_ipv6_out, after nat is done, nf_xfrm_me_harder()
> will be called to look up xfrm dst.
>
> Signed-off-by: Duan Jiong <duanj.fnst@cn.fujitsu.com>
This is far from sufficient of a commit log message for a change that
is as serious and has as many implications as this one.
You haven't answered many questions, first of which in my mind is
why we are bypassing all of the fragmentation checks?
We're also bypassing ip6_finish_output2() which does multicast and
hooks up the neighbour.
IPV4 doesn't do this, why doesn't it have the same supposed problem
you are trying to solve?
It is not even clear to me what the problem is, because your commit
message is way too terse.
next prev parent reply other threads:[~2014-11-03 19:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 4:53 [PATCH] ipv6: do xfrm transform after nat if necessary Duan Jiong
2014-11-03 19:42 ` David Miller [this message]
2014-11-04 1:14 ` Duan Jiong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103.144234.1037182010018495486.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=duanj.fnst@cn.fujitsu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).