From: David Miller <davem@davemloft.net>
To: b38611@freescale.com
Cc: netdev@vger.kernel.org, festevam@gmail.com
Subject: Re: [PATCH] net: fec: fix suspend broken on multiple MACs sillicons
Date: Mon, 03 Nov 2014 14:50:38 -0500 (EST) [thread overview]
Message-ID: <20141103.145038.1224937667378001886.davem@davemloft.net> (raw)
In-Reply-To: <1414992410-27886-1-git-send-email-b38611@freescale.com>
From: Fugang Duan <b38611@freescale.com>
Date: Mon, 3 Nov 2014 13:26:50 +0800
> On i.MX6SX sdb platform, there has two same enet MACs, after system up,
> just eth0 is up, and then do suspend/resume test:
...
> The root cause is that eth1 is not opened and clock is not enabled, and .suspend() still
> call .fec_enet_clk_enable() to disable clock.
>
> To avoid the broken, let it check network device up status by calling .netif_running()
> before disable/enable clocks.
>
> Signed-off-by: Fugang Duan <B38611@freescale.com>
Applied, thanks!
prev parent reply other threads:[~2014-11-03 19:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 5:26 [PATCH] net: fec: fix suspend broken on multiple MACs sillicons Fugang Duan
2014-11-03 19:50 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103.145038.1224937667378001886.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=b38611@freescale.com \
--cc=festevam@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).