From: Robert Richter <robert.richter@caviumnetworks.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Sunil Kovvuri <sunil.kovvuri@gmail.com>,
Robert Richter <rric@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Sunil Goutham <sgoutham@cavium.com>,
Stefan Assmann <sassmann@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
LAKML <linux-arm-kernel@lists.infradead.org>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH] VNIC: Adding support for Cavium ThunderX network controller
Date: Mon, 3 Nov 2014 19:33:45 +0100 [thread overview]
Message-ID: <20141103183345.GK31556@rric.localhost> (raw)
In-Reply-To: <20141103101651.1d664cc3@urahara>
On 03.11.14 10:16:51, Stephen Hemminger wrote:
> On Fri, 31 Oct 2014 22:44:11 +0530
> Sunil Kovvuri <sunil.kovvuri@gmail.com> wrote:
>
> > On Fri, Oct 31, 2014 at 8:24 AM, Stephen Hemminger
> > <stephen@networkplumber.org> wrote:
> > > On Thu, 30 Oct 2014 17:54:34 +0100
> > > Robert Richter <rric@kernel.org> wrote:
> > >
> > >> +#ifdef VNIC_RSS_SUPPORT
> > >> +static int rss_config = RSS_IP_HASH_ENA | RSS_TCP_HASH_ENA | RSS_UDP_HASH_ENA;
> > >> +module_param(rss_config, int, S_IRUGO);
> > >> +MODULE_PARM_DESC(rss_config,
> > >> + "RSS hash config [bits 8:0] (Bit0:L2 extended, 1:IP, 2:TCP, 3:TCP SYN, 4:UDP, 5:L4 extended, 6:ROCE 7:L3 bi-directional, 8:L4 bi-directional)");
> > >> +#endif
> > >
> > > This should managed be via ethtool ETHTOOL_GRXFH rather than a module parameter.
> > Thanks, i will add setting hash options via ETHTOOL_SRXFH as well.
> > The idea here is to have a choice of hash while module load (through
> > module params) and if it needs to be changed runtime then
> > via Ethtool.
> >
> > Sunil.
>
> Network developers do not like vendor unique module parameters.
> Anything device specific doesn't work in a generic distro environment.
Do you accept unique module parameters in parallel to ethtool support
or should this be removed?
-Robert
next prev parent reply other threads:[~2014-11-03 18:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 16:54 [PATCH] VNIC: Adding support for Cavium ThunderX network controller Robert Richter
2014-10-31 2:45 ` Stephen Hemminger
2014-10-31 16:17 ` Robert Richter
2014-10-31 2:54 ` Stephen Hemminger
2014-10-31 17:14 ` Sunil Kovvuri
2014-11-03 18:16 ` Stephen Hemminger
2014-11-03 18:33 ` Robert Richter [this message]
2014-11-03 20:25 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141103183345.GK31556@rric.localhost \
--to=robert.richter@caviumnetworks.com \
--cc=davem@davemloft.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rric@kernel.org \
--cc=sassmann@redhat.com \
--cc=sgoutham@cavium.com \
--cc=stephen@networkplumber.org \
--cc=sunil.kovvuri@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).