From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: xiyou.wangcong@gmail.com, netdev@vger.kernel.org, jhs@mojatatu.com
Subject: Re: [PATCH 00/13] net_sched: misc cleanups and improvements
Date: Tue, 04 Nov 2014 14:56:18 -0500 (EST) [thread overview]
Message-ID: <20141104.145618.511225947658504800.davem@davemloft.net> (raw)
In-Reply-To: <1415125250.25370.2.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 04 Nov 2014 10:20:50 -0800
> On Tue, 2014-11-04 at 09:56 -0800, Cong Wang wrote:
>> Minor code cleanups for TC qdiscs and filters, each patch has
>> more details.
>>
>> Cong Wang (13):
>> net_sched: refactor out tcf_exts
>> net_sched: introduce qdisc_peek() helper function
>> net_sched: rename ->gso_skb to ->dequeued_skb
>> net_sched: rename qdisc_drop() to qdisc_drop_skb()
>> net_sched: introduce qdisc_drop() helper function
>> net_sched: move some qdisc flag into qdisc ops
>> net_sched: move TCQ_F_MQROOT into qdisc ops
>> net_sched: use a flag to indicate fifo qdiscs instead of the name
>> net_sched: redefine qdisc_create_dflt()
>> net_sched: forbid setting default qdisc to inappropriate ones
>> net_sched: remove hashmask from Qdisc_class_hash
>> net_sched: remove useless qdisc_stab_lock
>> net_sched: return NULL instead of ERR_PTR for qdisc_alloc()
>>
>
> NACK for the whole serie.
>
> I am tired of your inexistent changelogs and code churn in qdisc.
>
> If you do not care of writing good changelogs and explain why you want
> all this, why should I care spending time to review all this stuff ?
>
> What is the plan, beyond all this code churn ?
+1
next prev parent reply other threads:[~2014-11-04 19:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 17:56 [PATCH 00/13] net_sched: misc cleanups and improvements Cong Wang
2014-11-04 17:56 ` [PATCH 01/13] net_sched: refactor out tcf_exts Cong Wang
2014-11-04 17:56 ` [PATCH 02/13] net_sched: introduce qdisc_peek() helper function Cong Wang
2014-11-04 18:45 ` Stephen Hemminger
2014-11-05 1:05 ` Cong Wang
2014-11-05 3:49 ` Herbert Xu
2014-11-06 2:50 ` Cong Wang
2014-11-04 17:56 ` [PATCH 03/13] net_sched: rename ->gso_skb to ->dequeued_skb Cong Wang
2014-11-04 17:56 ` [PATCH 04/13] net_sched: rename qdisc_drop() to qdisc_drop_skb() Cong Wang
2014-11-04 17:56 ` [PATCH 05/13] net_sched: introduce qdisc_drop() helper function Cong Wang
2014-11-04 17:56 ` [PATCH 06/13] net_sched: move some qdisc flag into qdisc ops Cong Wang
2014-11-04 17:56 ` [PATCH 07/13] net_sched: move TCQ_F_MQROOT " Cong Wang
2014-11-04 17:56 ` [PATCH 08/13] net_sched: use a flag to indicate fifo qdiscs instead of the name Cong Wang
2014-11-04 17:56 ` [PATCH 09/13] net_sched: redefine qdisc_create_dflt() Cong Wang
2014-11-04 17:56 ` [PATCH 10/13] net_sched: forbid setting default qdisc to inappropriate ones Cong Wang
2014-11-04 17:56 ` [PATCH 11/13] net_sched: remove hashmask from Qdisc_class_hash Cong Wang
2014-11-04 17:56 ` [PATCH 12/13] net_sched: remove useless qdisc_stab_lock Cong Wang
2014-11-04 17:56 ` [PATCH 13/13] net_sched: return NULL instead of ERR_PTR for qdisc_alloc() Cong Wang
2014-11-04 18:20 ` [PATCH 00/13] net_sched: misc cleanups and improvements Eric Dumazet
2014-11-04 19:56 ` David Miller [this message]
2014-11-05 1:25 ` Cong Wang
2014-11-05 1:47 ` Eric Dumazet
2014-11-06 18:05 ` Cong Wang
2014-11-06 18:17 ` Eric Dumazet
2014-11-06 19:03 ` David Miller
2014-11-06 18:21 ` Eric Dumazet
2014-11-06 19:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104.145618.511225947658504800.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).