* [PATCH V2 net-next] esp4: remove assignment in if condition
@ 2014-11-04 21:54 Fabian Frederick
2014-11-04 21:58 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-11-04 21:54 UTC (permalink / raw)
To: linux-kernel
Cc: Joe Perches, Fabian Frederick, Steffen Klassert, Herbert Xu,
David S. Miller, Alexey Kuznetsov, James Morris,
Hideaki YOSHIFUJI, Patrick McHardy, netdev
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
V2: remove blank line between set and test (suggested by Joe Perches).
net/ipv4/esp4.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/net/ipv4/esp4.c b/net/ipv4/esp4.c
index 360b565..d2bf02e 100644
--- a/net/ipv4/esp4.c
+++ b/net/ipv4/esp4.c
@@ -392,8 +392,10 @@ static int esp_input(struct xfrm_state *x, struct sk_buff *skb)
if (elen <= 0)
goto out;
- if ((err = skb_cow_data(skb, 0, &trailer)) < 0)
+ err = skb_cow_data(skb, 0, &trailer);
+ if (err < 0)
goto out;
+
nfrags = err;
assoclen = sizeof(*esph);
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH V2 net-next] esp4: remove assignment in if condition
2014-11-04 21:54 [PATCH V2 net-next] esp4: remove assignment in if condition Fabian Frederick
@ 2014-11-04 21:58 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-11-04 21:58 UTC (permalink / raw)
To: fabf
Cc: linux-kernel, joe, steffen.klassert, herbert, kuznet, jmorris,
yoshfuji, kaber, netdev
From: Fabian Frederick <fabf@skynet.be>
Date: Tue, 4 Nov 2014 22:54:36 +0100
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> V2: remove blank line between set and test (suggested by Joe Perches).
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-04 21:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-04 21:54 [PATCH V2 net-next] esp4: remove assignment in if condition Fabian Frederick
2014-11-04 21:58 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).