From: David Miller <davem@davemloft.net>
To: peppe.cavallaro@st.com
Cc: andriy.shevchenko@linux.intel.com, netdev@vger.kernel.org,
hock.leong.kweh@intel.com, vbridgers2013@gmail.com
Subject: Re: [PATCH] stmmac: fix sparse warnings
Date: Tue, 04 Nov 2014 16:59:58 -0500 (EST) [thread overview]
Message-ID: <20141104.165958.657451417783601838.davem@davemloft.net> (raw)
In-Reply-To: <54590045.3050305@st.com>
From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
Date: Tue, 4 Nov 2014 17:35:17 +0100
> On 11/3/2014 6:28 PM, Andy Shevchenko wrote:
>> This patch fixes the following sparse warnings.
>>
>> drivers/net/ethernet/stmicro/stmmac/enh_desc.c:381:30: warning: symbol
>> 'enh_desc_ops' was not declared. Should it be static?
>> drivers/net/ethernet/stmicro/stmmac/norm_desc.c:253:30: warning:
>> symbol 'ndesc_ops' was not declared. Should it be static?
>> drivers/net/ethernet/stmicro/stmmac/stmmac_hwtstamp.c:141:33: warning:
>> symbol 'stmmac_ptp' was not declared. Should it be static?
>>
>> There is no functional change.
>
> Hello Andy
>
> I have never seen this kind of warnings.
Are you running the 'sparse' checker with all options enabled?
This is one of the most fundamental warnings it spits out.
> I prefer to not include the
> stmmac.h in enh_desc.c and norm_desc.c but eventually to move the
> following from stmmac.h to common.h:
> extern const struct stmmac_desc_ops enh_desc_ops;
> extern const struct stmmac_desc_ops ndesc_ops;
> what do you think?
You two sort this out and submit a new patch, thanks.
next prev parent reply other threads:[~2014-11-04 22:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 17:28 [PATCH] stmmac: fix sparse warnings Andy Shevchenko
2014-11-03 17:28 ` [PATCH] stmmac: remove custom implementation of print_hex_dump() Andy Shevchenko
2014-11-03 17:39 ` Joe Perches
2014-11-03 17:53 ` Andy Shevchenko
2014-11-03 18:11 ` Joe Perches
2014-11-04 16:35 ` [PATCH] stmmac: fix sparse warnings Giuseppe CAVALLARO
2014-11-04 21:59 ` David Miller [this message]
2014-11-05 9:03 ` Andy Shevchenko
2014-11-05 9:27 ` Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104.165958.657451417783601838.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andriy.shevchenko@linux.intel.com \
--cc=hock.leong.kweh@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=vbridgers2013@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).