Re: [PATCH 1/1] ip-link: in human readable output use dynamic precision length

[Christian Hesse <mail@eworm.de>]

[-- Attachment #1: Type: text/plain, Size: 969 bytes --]

Christian Hesse <mail@eworm.de> on Tue, 2014/11/04 10:39:
> Now that we use floating point numbers for human readable output we can
> calculate precision length on the fly.
> ---
>  ip/ipaddress.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/ip/ipaddress.c b/ip/ipaddress.c
> index e240bb5..0ddcb0d 100644
> --- a/ip/ipaddress.c
> +++ b/ip/ipaddress.c
> @@ -343,8 +343,8 @@ static void print_num(FILE *fp, unsigned width,
> uint64_t count) ++prefix;
>  	}
>  
> -	snprintf(buf, sizeof(buf), "%.1f%c%s", (double) count / powi, 
> -		 *prefix, use_iec ? "i" : "");
> +	snprintf(buf, sizeof(buf), "%.*f%c%s", 3 - snprintf(NULL, 0,
> "%"PRIu64, count / powi),
> +		(double) count / powi, *prefix, use_iec ? "i" : "");
>  
>  	fprintf(fp, "%-*s ", width, buf);
>  }

Damn... In IEC mode we have negative precision length for values between 1000
and 1024. Will send a new patch.
-- 
Best Regards,
Christian Hesse

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]