From: David Miller <davem@davemloft.net>
To: peppe.cavallaro@st.com
Cc: netdev@vger.kernel.org
Subject: Re: [net-next.git 0/3 (v2)] stmmac: review driver Koptions
Date: Wed, 05 Nov 2014 16:15:33 -0500 (EST) [thread overview]
Message-ID: <20141105.161533.301569812388792280.davem@davemloft.net> (raw)
In-Reply-To: <1415112574-21321-1-git-send-email-peppe.cavallaro@st.com>
From: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Date: Tue, 4 Nov 2014 15:49:31 +0100
> Recently many Koption options have been added to have new glue logic on several
> platforms.
>
> The main goal behind this work is to guarantee that the driver built
> fine on all the branches where it is present independently of which
> glue logic is selected.
>
> IMHO, it is better to remove all the not necessary Koption(s) that can hide
> build problems when something changes in the driver and especially when
> the DT compatibility allows us to manage all the platform data.
>
> I compiled the driver w/o any issue on net-next Git for:
>
> x86, arm and sh4.
>
> In case of there are build problems on some repos now it will be
> easy to catch them and cherry-pick patches from mainstream.
>
> For sure, do not hesitate to contact me in case of issue.
>
> Also this set removes STMMAC_DEBUG_FS and BUS_MODE_DA. The latter is useless
> and the former can be replaced by DEBUG_FS (always to make safe the build).
>
> V2: patch-set re-based on top of the latest updates for net-next
Series applied, thanks.
prev parent reply other threads:[~2014-11-05 21:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 14:49 [net-next.git 0/3 (v2)] stmmac: review driver Koptions Giuseppe Cavallaro
2014-11-04 14:49 ` [net-next.git 1/3 (V2)] stmmac: remove specific SoC Koption from platform Giuseppe Cavallaro
2014-11-04 14:49 ` [net-next.git 2/3 (V2)] stmmac: remove STMMAC_DEBUG_FS Giuseppe Cavallaro
2014-11-04 14:49 ` [net-next.git 3/3 (V2)] stmmac: remove BUS_MODE_DA Giuseppe Cavallaro
2014-11-05 21:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141105.161533.301569812388792280.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox