From: David Miller <davem@davemloft.net>
To: peppe.cavallaro@st.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH (net.git) 0/5] stmmac: review and fix lock and atomicity
Date: Wed, 05 Nov 2014 16:24:08 -0500 (EST) [thread overview]
Message-ID: <20141105.162408.776250626924229773.davem@davemloft.net> (raw)
In-Reply-To: <1415117289-7733-1-git-send-email-peppe.cavallaro@st.com>
From: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Date: Tue, 4 Nov 2014 17:08:04 +0100
> Recently some issues have been reported for the driver for locking mechanism
> and atomicity.
>
> In fact, enabling DEBUG support to prove lock and to verify if sleeping while
> atomic context some warnings occur at runtime. I have reproduced all on STi
> platforms.
>
> Concerning the tx path, I had provided a patch time ago but
> I discarded the idea to completely remove locks; in this patch-set we can have
> some useful fixes instead of.
>
> This patch-set is to fix the atomicity in the PM stuff where I tried to collect
> all the points and advice reported in the past weeks.
> As final result, on my side no warnings and no problem when suspend/resume the
> driver on STi boxes.
>
> I also added a patch that fixes the locks for the EEE.
> As pointed in some thread there was a design problem behind the eee
> initialization and I have tried to fix that before.
> As final result no issues when proving locks too.
Series applied, thanks.
prev parent reply other threads:[~2014-11-05 21:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 16:08 [PATCH (net.git) 0/5] stmmac: review and fix lock and atomicity Giuseppe Cavallaro
2014-11-04 16:08 ` [PATCH (net.git) 1/5] stmmac: fix stmmac_tx_avail should be called with TX locked Giuseppe Cavallaro
2014-11-04 16:08 ` [PATCH (net.git) 2/5] stmmac: release tx lock, in case of dma mapping error Giuseppe Cavallaro
2014-11-04 16:08 ` [PATCH (net.git) 3/5] stmmac: fix lock in stmmac_set_rx_mode Giuseppe Cavallaro
2014-11-04 16:08 ` [PATCH (net.git) 4/5] stmmac: fix concurrency in eee initialization Giuseppe Cavallaro
2014-11-04 16:08 ` [PATCH (net.git) 5/5] stmmac: fix atomicity in pm routines Giuseppe Cavallaro
2014-11-05 21:24 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141105.162408.776250626924229773.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox