From: David Miller <davem@davemloft.net>
To: gerlitz.or@gmail.com
Cc: therbert@google.com, joestringer@nicira.com,
	netdev@vger.kernel.org, sathya.perla@emulex.com,
	jeffrey.t.kirsher@intel.com, linux.nics@intel.com,
	amirv@mellanox.com, shahed.shaikh@qlogic.com,
	Dept-GELinuxNICDev@qlogic.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net 0/5] Implement ndo_gso_check() for vxlan nics
Date: Wed, 05 Nov 2014 16:38:25 -0500 (EST)	[thread overview]
Message-ID: <20141105.163825.1433973842938441546.davem@davemloft.net> (raw)
In-Reply-To: <CAJ3xEMhxabp1EKbFPfvoZEFt=CQKFNcNrURGMX=7miDwmK9Y-A@mail.gmail.com>
From: Or Gerlitz <gerlitz.or@gmail.com>
Date: Wed, 5 Nov 2014 23:32:44 +0200
> but fact is that the proposed patch series has the --same-- helper for
> four drivers, so why not start with a that limited helper which would
> be picked up by these drivers and we'll take it from there.
I'm in favor of the helper, duplication is error prone.
And in fact, any differences a driver ends up needing might be
integratable into the helper.
next prev parent reply	other threads:[~2014-11-05 21:38 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-04 21:56 [PATCH net 0/5] Implement ndo_gso_check() for vxlan nics Joe Stringer
2014-11-04 21:56 ` [PATCH net 1/5] be2net: Implement ndo_gso_check() Joe Stringer
2014-11-04 21:56 ` [PATCH net 2/5] i40e: " Joe Stringer
2014-11-04 23:45   ` Jesse Gross
2014-11-05 12:37     ` Jeff Kirsher
2014-11-20 19:16     ` Joe Stringer
2014-11-20 20:14       ` Jesse Gross
2014-11-05 12:35   ` Jeff Kirsher
2014-11-04 21:56 ` [PATCH net 3/5] fm10k: " Joe Stringer
2014-11-05 12:34   ` [linux-nics] " Jeff Kirsher
2014-11-05 12:44     ` Or Gerlitz
2014-11-05 12:47       ` Jeff Kirsher
     [not found]         ` <CANr6G5xBehKGVozOAM=m8CXY7Q8_kPu-s5zgwho4=npv=bQsrg@mail.gmail.com>
2014-11-05 19:36           ` Jeff Kirsher
     [not found]             ` <D0814A3F.5EA53%matthew.vick@intel.com>
2014-11-07  0:55               ` Joe Stringer
     [not found]                 ` <D0815B72.5EAF9%matthew.vick@intel.com>
2014-11-07  4:51                   ` Joe Stringer
2014-11-06  2:54   ` Alexander Duyck
2014-11-06 18:41     ` Joe Stringer
2014-11-06 21:15       ` Joe Stringer
2014-11-07  1:07         ` Vick, Matthew
2014-11-07  5:05           ` Joe Stringer
2014-11-07 19:49             ` Vick, Matthew
2014-11-07 22:35               ` Joe Stringer
2014-11-08  0:51                 ` Vick, Matthew
2014-11-04 21:56 ` [PATCH net 4/5] net/mlx4_en: " Joe Stringer
2014-11-05 12:41   ` Or Gerlitz
2014-11-04 21:56 ` [PATCH net 5/5] qlcnic: " Joe Stringer
2014-11-05  9:17   ` Shahed Shaikh
2014-11-05 12:38 ` [PATCH net 0/5] Implement ndo_gso_check() for vxlan nics Or Gerlitz
     [not found]   ` <CANr6G5xtNYenhd8KDWx+kRcnSZ0fahUdAL+6Wcz=5_dNvrQR6Q@mail.gmail.com>
2014-11-05 18:00     ` Tom Herbert
2014-11-05 21:32       ` Or Gerlitz
2014-11-05 21:38         ` David Miller [this message]
2014-11-06  1:06           ` Joe Stringer
2014-11-06  2:15             ` David Miller
2014-11-06  2:44               ` Tom Herbert
2014-11-06  8:23                 ` Or Gerlitz
     [not found]                 ` <CF9D1877D81D214CB0CA0669EFAE020C68CC79EF@CMEXMB1.ad.emulex.com>
2014-11-06 16:06                   ` Tom Herbert
2014-11-06 16:15                     ` Jesse Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=20141105.163825.1433973842938441546.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Dept-GELinuxNICDev@qlogic.com \
    --cc=amirv@mellanox.com \
    --cc=gerlitz.or@gmail.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=joestringer@nicira.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux.nics@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=sathya.perla@emulex.com \
    --cc=shahed.shaikh@qlogic.com \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).