From: David Miller <davem@davemloft.net>
To: ncardwell@google.com
Cc: mleitner@redhat.com, netdev@vger.kernel.org, ycheng@google.com,
edumazet@google.com
Subject: Re: [PATCH v2 net] tcp: zero retrans_stamp if all retrans were acked
Date: Wed, 05 Nov 2014 17:00:44 -0500 (EST) [thread overview]
Message-ID: <20141105.170044.838421908925675417.davem@davemloft.net> (raw)
In-Reply-To: <CADVnQymMioK0USNpaOF2Kb4+zMTDrjJ7r=5Bu51LbirVQPnzyw@mail.gmail.com>
From: Neal Cardwell <ncardwell@google.com>
Date: Tue, 4 Nov 2014 15:10:31 -0500
> On Tue, Nov 4, 2014 at 2:15 PM, Marcelo Ricardo Leitner
> <mleitner@redhat.com> wrote:
> ...
>> Therefore, now we clear retrans_stamp as soon as all data during the
>> loss window is fully acked.
>>
>> Reported-by: Ueki Kohei
>> Cc: Neal Cardwell <ncardwell@google.com>
>> Cc: Yuchung Cheng <ycheng@google.com>
>> Signed-off-by: Marcelo Ricardo Leitner <mleitner@redhat.com>
>> ---
>>
>> Notes:
>> v1->v2: fixed compilation issue noticed by Neal
>>
>> net/ipv4/tcp_input.c | 60 +++++++++++++++++++++++++++-------------------------
>> 1 file changed, 31 insertions(+), 29 deletions(-)
>
> Acked-by: Neal Cardwell <ncardwell@google.com>
> Tested-by: Neal Cardwell <ncardwell@google.com>
>
> Code looks fine, and it passes Yuchung's packetdrill test case for this.
>
> Thanks for finding and fixing this, Marcelo.
Applied, thanks everyone.
prev parent reply other threads:[~2014-11-05 22:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 14:18 [PATCH net] tcp: zero retrans_stamp if all retrans were acked Marcelo Ricardo Leitner
2014-11-04 18:51 ` Neal Cardwell
2014-11-04 19:03 ` Neal Cardwell
2014-11-04 19:12 ` Marcelo Ricardo Leitner
2014-11-04 19:15 ` [PATCH v2 " Marcelo Ricardo Leitner
2014-11-04 20:10 ` Neal Cardwell
2014-11-04 20:51 ` Marcelo Ricardo Leitner
2014-11-05 1:20 ` Eric Dumazet
2014-11-05 15:32 ` Marcelo Ricardo Leitner
2014-11-05 22:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141105.170044.838421908925675417.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=mleitner@redhat.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=ycheng@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).