netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Westphal <fw@strlen.de>
To: Or Gerlitz <ogerlitz@mellanox.com>
Cc: Florian Westphal <fw@strlen.de>,
	netdev@vger.kernel.org, Tom Herbert <therbert@google.com>,
	Jesse Gross <jesse@nicira.com>,
	amirv@mellanox.com
Subject: Re: mlx4+vxlan offload breaks gre tunnels
Date: Wed, 5 Nov 2014 17:53:51 +0100	[thread overview]
Message-ID: <20141105165351.GA23131@breakpoint.cc> (raw)
In-Reply-To: <545A4DB7.5010603@mellanox.com>

Or Gerlitz <ogerlitz@mellanox.com> wrote:
> On 11/5/2014 5:04 PM, Florian Westphal wrote:
> >tl,dr: all tcp packets sent via gre tunnel have broken tcp csum if vxlan offload
> >is enabled with mlx4 driver.
> >
> Yep, I can see now the problem. It comes into play with
> ConnectX3-pro NICs that support VXLAN offloads (but not with
> ConnectX3 NIC which don't) when you enable the offloads support on
> the CX3-pro.

[..]
> I think the best effort we can do now is
> 
> 1. come up with something such as the below patch for 3.18 which is
> back-ward portable for -stable kernels, it will only arm the hw
> offloads if the OS tells us there's VXLAN in action
> 
[..]
> 
> tested to work with the  following which is a bit different, tell me
> if it works for you

Right, the patch below works in my setup as well (until link-add-vxlan,
that is ;) )

Thanks,
Florian

  reply	other threads:[~2014-11-05 16:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-05 15:04 mlx4+vxlan offload breaks gre tunnels Florian Westphal
2014-11-05 16:17 ` Or Gerlitz
2014-11-05 16:53   ` Florian Westphal [this message]
2014-11-06 16:30     ` Or Gerlitz
2014-11-05 21:59   ` Tom Herbert
2014-11-06  7:03     ` Or Gerlitz
2014-11-06  7:21   ` Sathya Perla
2014-11-06  7:53     ` Or Gerlitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141105165351.GA23131@breakpoint.cc \
    --to=fw@strlen.de \
    --cc=amirv@mellanox.com \
    --cc=jesse@nicira.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=therbert@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).