netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, ogerlitz@mellanox.com, willemb@google.com
Subject: Re: [PATCH net-next] net: gro: add a per device gro flush timer
Date: Thu, 06 Nov 2014 16:25:16 -0500 (EST)	[thread overview]
Message-ID: <20141106.162516.1083429539800319166.davem@davemloft.net> (raw)
In-Reply-To: <1415235320.13896.51.camel@edumazet-glaptop2.roam.corp.google.com>

From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Wed, 05 Nov 2014 16:55:20 -0800

> @@ -4430,8 +4432,19 @@ void napi_complete(struct napi_struct *n)
>  	if (unlikely(test_bit(NAPI_STATE_NPSVC, &n->state)))
>  		return;
>  
> -	napi_gro_flush(n, false);
> +	if (n->gro_list) {
> +		unsigned long timeout = 0;
> +
> +		if (n->napi_rx_count)
> +			timeout = n->dev->gro_flush_timeout;

Under what circumstances would we see n->gro_list non-NULL yet
n->napi_rx_count == 0?

I'm not so sure it can happen.

Said another way, it looks to me like you could implement this
using less state.

  parent reply	other threads:[~2014-11-06 21:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-06  0:55 [PATCH net-next] net: gro: add a per device gro flush timer Eric Dumazet
2014-11-06  1:38 ` Rick Jones
2014-11-06  2:14   ` Eric Dumazet
2014-11-06  2:39     ` Eric Dumazet
2014-11-06 16:42       ` Rick Jones
2014-11-06 21:25 ` David Miller [this message]
2014-11-06 22:11   ` Eric Dumazet
2014-11-07  3:36     ` David Miller
2014-11-07  4:15       ` Eric Dumazet
2014-11-07  5:09       ` [PATCH v2 net-next 1/2] " Eric Dumazet
2014-11-07 22:00         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141106.162516.1083429539800319166.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).