Netdev List
 help / color / mirror / Atom feed
From: David Miller <davem@redhat.com>
To: raj@tardy.usa.hp.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v4 net-next] udp: Increment UDP_MIB_IGNOREDMULTI for arriving unmatched multicasts
Date: Fri, 07 Nov 2014 15:46:47 -0500 (EST)	[thread overview]
Message-ID: <20141107.154647.1153472232949337302.davem@redhat.com> (raw)
In-Reply-To: <20141106183754.8A52829007D9@tardy>

From: raj@tardy.usa.hp.com (Rick Jones)
Date: Thu,  6 Nov 2014 10:37:54 -0800 (PST)

> From: Rick Jones <rick.jones2@hp.com>
> 
> As NIC multicast filtering isn't perfect, and some platforms are
> quite content to spew broadcasts, we should not trigger an event
> for skb:kfree_skb when we do not have a match for such an incoming
> datagram.  We do though want to avoid sweeping the matter under the
> rug entirely, so increment a suitable statistic.
> 
> This incorporates feedback from David L. Stevens, Karl Neiss and Eric
> Dumazet.
> 
> V3 - use bool per David Miller
> 
> Signed-off-by: Rick Jones <rick.jones2@hp.com>

Applied, thanks Rick.

      reply	other threads:[~2014-11-07 20:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-06 18:37 [PATCH v4 net-next] udp: Increment UDP_MIB_IGNOREDMULTI for arriving unmatched multicasts Rick Jones
2014-11-07 20:46 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20141107.154647.1153472232949337302.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=raj@tardy.usa.hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox