From: Jesse Brandeburg <jesse.brandeburg@intel.com>
To: Or Gerlitz <gerlitz.or@gmail.com>
Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
David Miller <davem@davemloft.net>,
Kamil Krawczyk <kamil.krawczyk@intel.com>,
Linux Netdev List <netdev@vger.kernel.org>, <nhorman@redhat.com>,
<sassmann@redhat.com>, <jogreene@redhat.com>,
jesse.brandeburg@intel.com
Subject: Re: [net-next 1/9] i40e: poll firmware slower
Date: Fri, 7 Nov 2014 15:02:23 -0800 [thread overview]
Message-ID: <20141107150223.00004b23@unknown> (raw)
In-Reply-To: <CAJ3xEMghFwT8Tm9wONzLPL4MLvgL+3w=CNRNg0Hb=yGJ9uR0Mg@mail.gmail.com>
On Fri, 7 Nov 2014 15:29:15 +0200
Or Gerlitz <gerlitz.or@gmail.com> wrote:
> On Fri, Nov 7, 2014 at 10:57 AM, Jeff Kirsher
> <jeffrey.t.kirsher@intel.com> wrote:
> > The code was polling the firmware tail register for completion
>
> any reason not to sleep while waiting for this completion? can the
> firmware generate an interrupt?
The code path in question is called from the drivers when they are in
a synchronous context and can sleep or be rescheduled without issue.
An async mode is possible, but not here, because the code complexity
required to change to async mode is unmaintainable (if even doable, how
do you handle an interrupt while you're in probe?). We use async when
it is practical.
Thanks for your comments,
Jesse
next prev parent reply other threads:[~2014-11-07 23:02 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 8:57 [net-next 0/9][pull request] Intel Wired LAN Driver Updates 2014-11-07 Jeff Kirsher
2014-11-07 8:57 ` [net-next 1/9] i40e: poll firmware slower Jeff Kirsher
2014-11-07 9:40 ` David Laight
2014-11-07 22:58 ` Jesse Brandeburg
2014-11-07 13:29 ` Or Gerlitz
2014-11-07 23:02 ` Jesse Brandeburg [this message]
2014-11-07 8:57 ` [net-next 2/9] i40e: don't do link_status or stats collection on every ARQ Jeff Kirsher
2014-11-07 8:57 ` [net-next 3/9] i40e: clean up throttle rate code Jeff Kirsher
2014-11-07 8:57 ` [net-next 4/9] i40evf: make early init processing more robust Jeff Kirsher
2014-11-07 8:57 ` [net-next 5/9] i40evf: don't use more queues than CPUs Jeff Kirsher
2014-11-07 8:57 ` [net-next 6/9] ixgbe: fix X540 Completion timeout Jeff Kirsher
2014-11-07 14:35 ` Sergei Shtylyov
2014-11-07 17:06 ` Skidmore, Donald C
2014-11-07 8:57 ` [net-next 7/9] ixgbe: cleanup ixgbe_ndo_set_vf_vlan Jeff Kirsher
2014-11-07 8:57 ` [net-next 8/9] ixgbe: cleanup move setting PFQDE.HIDE_VLAN to support function Jeff Kirsher
2014-11-07 8:57 ` [net-next 9/9] ixgbe: Add new support for X550 MAC's Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141107150223.00004b23@unknown \
--to=jesse.brandeburg@intel.com \
--cc=davem@davemloft.net \
--cc=gerlitz.or@gmail.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jogreene@redhat.com \
--cc=kamil.krawczyk@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).