From: David Miller <davem@davemloft.net>
To: joe@perches.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
courmisch@gmail.com, nicolas.dichtel@6wind.com
Subject: Re: [PATCH V2 net-next] net: Convert LIMIT_NETDEBUG to net_dbg_ratelimited
Date: Tue, 11 Nov 2014 14:18:33 -0500 (EST) [thread overview]
Message-ID: <20141111.141833.1514022968668773382.davem@davemloft.net> (raw)
In-Reply-To: <1415732357.16070.8.camel@perches.com>
From: Joe Perches <joe@perches.com>
Date: Tue, 11 Nov 2014 10:59:17 -0800
> Use the more common dynamic_debug capable net_dbg_ratelimited
> and remove the LIMIT_NETDEBUG macro.
>
> All messages are still ratelimited.
>
> Some KERN_<LEVEL> uses are changed to KERN_DEBUG.
>
> This may have some negative impact on messages that were
> emitted at KERN_INFO that are not not enabled at all unless
> DEBUG is defined or dynamic_debug is enabled. Even so,
> these messages are now _not_ emitted by default.
>
> This also eliminates the use of the net_msg_warn sysctl
> "/proc/sys/net/core/warnings". For backward compatibility,
> the sysctl is not removed, but it has no function. The extern
> declaration of net_msg_warn is removed from sock.h and made
> static in net/core/sysctl_net_core.c
>
> Miscellanea:
>
> o Update the sysctl documentation
> o Remove the embedded uses of pr_fmt
> o Coalesce format fragments
> o Realign arguments
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
>
> V2: Remove the EXPORT_SYMBOL for net_msg_warn and make
> it a static in net/core/sysctl_net_core.c
Applied, thanks a lot Joe.
next prev parent reply other threads:[~2014-11-11 19:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 23:36 [PATCH net-next] net: esp: Convert NETDEBUG to pr_info Joe Perches
2014-11-05 23:42 ` [PATCH net-next] sock.h: Remove unused NETDEBUG macro Joe Perches
2014-11-06 20:11 ` David Miller
2014-11-06 20:53 ` [PATCH net-next] dccp: Convert DCCP_WARN to net_warn_ratelimited Joe Perches
2014-11-09 1:42 ` David Miller
2014-11-09 19:17 ` [RFC PATCH net-next] net: Convert LIMIT_NETDEBUG to net_dbg_ratelimited Joe Perches
2014-11-10 14:27 ` Nicolas Dichtel
2014-11-10 15:26 ` Joe Perches
2014-11-11 18:30 ` David Miller
2014-11-11 18:59 ` [PATCH V2 " Joe Perches
2014-11-11 19:18 ` David Miller [this message]
2014-11-06 20:11 ` [PATCH net-next] net: esp: Convert NETDEBUG to pr_info David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141111.141833.1514022968668773382.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=courmisch@gmail.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).