From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: dborkman@redhat.com, netdev@vger.kernel.org, nhorman@redhat.com,
sassmann@redhat.com, jogreene@redhat.com
Subject: Re: [net] ixgbe: phy: fix uninitialized status in ixgbe_setup_phy_link_tnx
Date: Tue, 11 Nov 2014 16:32:40 -0500 (EST) [thread overview]
Message-ID: <20141111.163240.790809900354066845.davem@davemloft.net> (raw)
In-Reply-To: <1415730125-13732-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Tue, 11 Nov 2014 10:22:05 -0800
> From: Daniel Borkmann <dborkman@redhat.com>
>
> Status variable is never initialized, can carry an arbitrary value
> on the stack and thus may let the function fail.
>
> Fixes: e90dd2645664 ("ixgbe: Make return values more direct")
> Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
> Acked-by: Emil Tantilov <emil.s.tantilov@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied, thanks Jeff.
prev parent reply other threads:[~2014-11-11 21:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 18:22 [net] ixgbe: phy: fix uninitialized status in ixgbe_setup_phy_link_tnx Jeff Kirsher
2014-11-11 21:32 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141111.163240.790809900354066845.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jogreene@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox