From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next v2 02/10] net: introduce generic switch devices support Date: Tue, 11 Nov 2014 11:04:09 +0100 Message-ID: <20141111100409.GB8106@nanopsycho.orion> References: <1415530280-9190-1-git-send-email-jiri@resnulli.us> <1415530280-9190-3-git-send-email-jiri@resnulli.us> <5461DBB0.5090107@fami-braun.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: netdev@vger.kernel.org, davem@davemloft.net, nhorman@tuxdriver.com, andy@greyhouse.net, tgraf@suug.ch, dborkman@redhat.com, ogerlitz@mellanox.com, jesse@nicira.com, pshelar@nicira.com, azhou@nicira.com, ben@decadent.org.uk, stephen@networkplumber.org, jeffrey.t.kirsher@intel.com, vyasevic@redhat.com, xiyou.wangcong@gmail.com, john.r.fastabend@intel.com, edumazet@google.com, jhs@mojatatu.com, sfeldma@gmail.com, f.fainelli@gmail.com, roopa@cumulusnetworks.com, linville@tuxdriver.com, jasowang@redhat.com, ebiederm@xmission.com, nicolas.dichtel@6wind.com, ryazanov.s.a@gmail.com, buytenh@wantstofly.org, aviadr@mellanox.com, nbd@openwrt.org, alexei.starovoitov@gmail.com, Neil.Jerram@metaswitch.com, ronye@mellanox.com, simon.horman@netronome.com, alexander.h.duyck@redhat.com, john.ronciak@intel.com, mleitner@redhat.com, shrijeet@gmail.com, gospo@cumulusnetworks.com, bcrl@kvac To: "M. Braun" Return-path: Received: from mail-wg0-f48.google.com ([74.125.82.48]:34595 "EHLO mail-wg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752592AbaKKKEL (ORCPT ); Tue, 11 Nov 2014 05:04:11 -0500 Received: by mail-wg0-f48.google.com with SMTP id y19so308409wgg.7 for ; Tue, 11 Nov 2014 02:04:10 -0800 (PST) Content-Disposition: inline In-Reply-To: <5461DBB0.5090107@fami-braun.de> Sender: netdev-owner@vger.kernel.org List-ID: Tue, Nov 11, 2014 at 10:49:36AM CET, michael-dev@fami-braun.de wrote: > > >Am 09.11.2014 um 11:51 schrieb Jiri Pirko: >> diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt >> + ndo_sw_parent_get_id - ... > >here the ndo is called get_id > >but > >> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h >> + * >> + * int (*ndo_sw_parent_id_get)(struct net_device *dev, >> + * struct netdev_phys_item_id *psid); >> @@ -1168,6 +1174,10 @@ struct net_device_ops { >> + int (*ndo_sw_parent_id_get)(struct net_device *dev, >> + struct netdev_phys_item_id *psid); > >here it is call id_get, which is similar but not the same. Will fix the docs, thanks. > >Regards, > M. Braun