From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Pirko Subject: Re: [patch net-next v2 05/10] rocker: introduce rocker switch driver Date: Tue, 11 Nov 2014 16:40:17 +0100 Message-ID: <20141111154017.GH1825@nanopsycho.lan> References: <1415530280-9190-1-git-send-email-jiri@resnulli.us> <1415530280-9190-6-git-send-email-jiri@resnulli.us> <5461366A.9050900@gmail.com> <20141111142946.GG19157@casper.infradead.org> <20141111151928.GF1825@nanopsycho.lan> <20141111153232.GH19157@casper.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: John Fastabend , netdev@vger.kernel.org, davem@davemloft.net, nhorman@tuxdriver.com, andy@greyhouse.net, dborkman@redhat.com, ogerlitz@mellanox.com, jesse@nicira.com, pshelar@nicira.com, azhou@nicira.com, ben@decadent.org.uk, stephen@networkplumber.org, jeffrey.t.kirsher@intel.com, vyasevic@redhat.com, xiyou.wangcong@gmail.com, john.r.fastabend@intel.com, edumazet@google.com, jhs@mojatatu.com, sfeldma@gmail.com, f.fainelli@gmail.com, roopa@cumulusnetworks.com, linville@tuxdriver.com, jasowang@redhat.com, ebiederm@xmission.com, nicolas.dichtel@6wind.com, ryazanov.s.a@gmail.com, buytenh@wantstofly.org, aviadr@mellanox.com, nbd@openwrt.org, alexei.starovoitov@gmail.com, Neil.Jerram@metaswitch.com, ronye@mellanox.com, simon.horman@netronome.com, alexander.h.duyck@redhat.com, john.ronciak@intel.com, mleitner@redhat.com, shrijeet@gmail.com, gospo@cum To: Thomas Graf Return-path: Received: from mail-wg0-f53.google.com ([74.125.82.53]:41570 "EHLO mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751249AbaKKPkU (ORCPT ); Tue, 11 Nov 2014 10:40:20 -0500 Received: by mail-wg0-f53.google.com with SMTP id b13so11942309wgh.26 for ; Tue, 11 Nov 2014 07:40:18 -0800 (PST) Content-Disposition: inline In-Reply-To: <20141111153232.GH19157@casper.infradead.org> Sender: netdev-owner@vger.kernel.org List-ID: Tue, Nov 11, 2014 at 04:32:32PM CET, tgraf@suug.ch wrote: >On 11/11/14 at 04:19pm, Jiri Pirko wrote: >> Tue, Nov 11, 2014 at 03:29:46PM CET, tgraf@suug.ch wrote: >> >On 11/10/14 at 02:04pm, John Fastabend wrote: >> >> On 11/09/2014 02:51 AM, Jiri Pirko wrote: >> >> >+static int rocker_port_sw_parent_id_get(struct net_device *dev, >> >> >+ struct netdev_phys_item_id *psid) >> >> >+{ >> >> >+ struct rocker_port *rocker_port = netdev_priv(dev); >> >> >+ struct rocker *rocker = rocker_port->rocker; >> >> >+ >> >> >> >> hmm looks like you read this out of a magic switch register :) but >> >> my switch doesn't have this magic reg. I suposse the switch MAC address >> >> should work. >> > >> >This needs more work afterwards. Either we define that the switch ID >> >is only unique in combination with the parent ifindex or we need to >> >introduce a notation of uniquness into the switch ID itself. >> >> This is something similar to physical port id. Each driver should take >> care of generating that id. > >If the ID is only unique within a driver, then the user space cannot >rely on using the ID to group switch ports. Multiple drivers might >come up with the same ID. Well, as I said, it is the same as for physical port id. But if needed, there can be added some simple mechanism for the id registration ensuring their uniqueness. > >Even now, multiple rocker instances would have the same ID. It depends on what hw returns to driver.