From: Steffen Klassert <steffen.klassert@secunet.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Ming Liu <ming.liu@windriver.com>, <davem@davemloft.net>,
<ying.xue@windriver.com>, <linux-crypto@vger.kernel.org>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH] crypto: aesni-intel - avoid IPsec re-ordering
Date: Wed, 12 Nov 2014 10:12:16 +0100 [thread overview]
Message-ID: <20141112091216.GM6390@secunet.com> (raw)
In-Reply-To: <20141112085148.GA26268@gondor.apana.org.au>
On Wed, Nov 12, 2014 at 04:51:48PM +0800, Herbert Xu wrote:
> On Wed, Nov 12, 2014 at 09:41:38AM +0100, Steffen Klassert wrote:
> >
> > Can't we just use cryptd unconditionally to fix this reordering problem?
>
> I think the idea is that most of the time cryptd isn't required
> so we want to stick with direct processing to lower latency.
Yes, I thought that. But is it really the case that doing it
asynchronous increases the latency? I tried this some time
ago and as far as I remember there was not too much difference
between the direct and the asynchronous case. Might depend
on the usecase of course.
>
> I think the simplest fix would be to punt to cryptd as long as
> there are cryptd requests queued.
This would be the second option. We may need to adjust the
maximum cryptd queue lenght then, as the networking receive
softirq might enqueue a lot of packets before cryptd can
process them.
next prev parent reply other threads:[~2014-11-12 9:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 5:49 [PATCH] crypto: aesni-intel - avoid IPsec re-ordering Ming Liu
2014-11-12 8:41 ` Steffen Klassert
2014-11-12 8:51 ` Herbert Xu
2014-11-12 9:12 ` Steffen Klassert [this message]
2014-11-12 10:41 ` Ming Liu
2014-11-12 11:43 ` Steffen Klassert
2014-11-13 1:52 ` Ming Liu
2014-11-12 10:41 ` Ming Liu
2014-11-12 11:48 ` Steffen Klassert
2014-11-13 1:53 ` Ming Liu
2014-11-15 3:15 ` Herbert Xu
2014-11-20 7:26 ` Steffen Klassert
2014-11-20 7:43 ` Herbert Xu
2014-11-20 7:59 ` Steffen Klassert
2014-11-20 8:02 ` Herbert Xu
2015-01-06 1:05 ` Sunderam K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141112091216.GM6390@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=ming.liu@windriver.com \
--cc=netdev@vger.kernel.org \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).