From: Steffen Klassert <steffen.klassert@secunet.com>
To: Ming Liu <ming.liu@windriver.com>
Cc: <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
<ying.xue@windriver.com>, <linux-crypto@vger.kernel.org>,
<netdev@vger.kernel.org>
Subject: Re: [PATCH] crypto: aesni-intel - avoid IPsec re-ordering
Date: Wed, 12 Nov 2014 12:48:59 +0100 [thread overview]
Message-ID: <20141112114859.GO6390@secunet.com> (raw)
In-Reply-To: <54633958.2080705@windriver.com>
On Wed, Nov 12, 2014 at 06:41:28PM +0800, Ming Liu wrote:
> On 11/12/2014 04:41 PM, Steffen Klassert wrote:
> >On Wed, Nov 12, 2014 at 01:49:31PM +0800, Ming Liu wrote:
> >> }
> >>@@ -147,11 +149,9 @@ static void cryptd_queue_worker(struct work_struct *work)
> >> preempt_disable();
> >> backlog = crypto_get_backlog(&cpu_queue->queue);
> >> req = crypto_dequeue_request(&cpu_queue->queue);
> >>- preempt_enable();
> >>- local_bh_enable();
> >Everything below the local_bh_enable() should not run in atomic context
> >as the subsequent functions may set the CRYPTO_TFM_REQ_MAY_SLEEP flag.
> If I turn off all the CRYPTO_TFM_REQ_MAY_SLEEP in cryptd.c, is that
> going to work?
Well, this might make the cryptd function accessible in atomic context,
but it does not solve the other problems with this approach. Also,
cryptd can be used to move requests out of atomic context and I think
it should stay as it is.
next prev parent reply other threads:[~2014-11-12 11:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 5:49 [PATCH] crypto: aesni-intel - avoid IPsec re-ordering Ming Liu
2014-11-12 8:41 ` Steffen Klassert
2014-11-12 8:51 ` Herbert Xu
2014-11-12 9:12 ` Steffen Klassert
2014-11-12 10:41 ` Ming Liu
2014-11-12 11:43 ` Steffen Klassert
2014-11-13 1:52 ` Ming Liu
2014-11-12 10:41 ` Ming Liu
2014-11-12 11:48 ` Steffen Klassert [this message]
2014-11-13 1:53 ` Ming Liu
2014-11-15 3:15 ` Herbert Xu
2014-11-20 7:26 ` Steffen Klassert
2014-11-20 7:43 ` Herbert Xu
2014-11-20 7:59 ` Steffen Klassert
2014-11-20 8:02 ` Herbert Xu
2015-01-06 1:05 ` Sunderam K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141112114859.GO6390@secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=ming.liu@windriver.com \
--cc=netdev@vger.kernel.org \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).