From: Michal Kubecek <mkubecek@suse.cz>
To: David Miller <davem@davemloft.net>
Cc: vfalico@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, j.vosburgh@gmail.com,
andy@greyhouse.net, jiri@resnulli.us
Subject: Re: [PATCH net-next 0/3] dev_disable_lro() improvements for stacked devices
Date: Wed, 12 Nov 2014 14:15:46 +0100 [thread overview]
Message-ID: <20141112131546.GA8745@unicorn.suse.cz> (raw)
In-Reply-To: <20141111.214752.266800170368088905.davem@davemloft.net>
On Tue, Nov 11, 2014 at 09:47:52PM -0500, David Miller wrote:
>
> Please do it generically.
>
> Having a special stanza for each layered device type in
> dev_disable_lro() is beyond stupid. Especially when it
> can in fact be done cleanly.
I gave it some thought and I would like ask one question first:
Does the upper-lower relationship always mean that upper device receives
packets through its lower device(s) so that LRO should always be
disabled for lower devices whenever there are some? Or should it be
limited only to an explicit list of device types (vlan, macvlan, bond,
team)?
Michal Kubecek
next prev parent reply other threads:[~2014-11-12 13:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 8:21 [PATCH net-next 0/3] dev_disable_lro() improvements for stacked devices Michal Kubecek
2014-11-11 8:21 ` [PATCH net-next 1/3] net: handle more general stacking in dev_disable_lro() Michal Kubecek
2014-11-11 8:21 ` [PATCH net-next 2/3] team: add helper to check if device is a team master Michal Kubecek
2014-11-11 8:22 ` [PATCH net-next 3/3] net: propagate LRO disabling to bond and team slaves Michal Kubecek
2014-11-11 9:05 ` [PATCH net-next 0/3] dev_disable_lro() improvements for stacked devices Veaceslav Falico
2014-11-11 9:34 ` Michal Kubecek
2014-11-12 2:47 ` David Miller
2014-11-12 13:15 ` Michal Kubecek [this message]
2014-11-12 20:08 ` David Miller
2014-11-13 6:54 ` [PATCH net-next v2] net: generic dev_disable_lro() stacked device handling Michal Kubecek
2014-11-13 7:15 ` Veaceslav Falico
2014-11-13 19:49 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141112131546.GA8745@unicorn.suse.cz \
--to=mkubecek@suse.cz \
--cc=andy@greyhouse.net \
--cc=davem@davemloft.net \
--cc=j.vosburgh@gmail.com \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vfalico@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).