* [PATCH net-next] sunvnet: fix NULL pointer dereference
@ 2014-11-12 15:58 David L Stevens
2014-11-12 16:12 ` Sowmini Varadhan
2014-11-12 18:51 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: David L Stevens @ 2014-11-12 15:58 UTC (permalink / raw)
To: David Miller; +Cc: netdev, Sowmini Varadhan
This patch fixes a NULL pointer dereference when __tx_port_find() doesn't
find a matching port.
Signed-off-by: David L Stevens <david.stevens@oracle.com>
---
drivers/net/ethernet/sun/sunvnet.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ethernet/sun/sunvnet.c b/drivers/net/ethernet/sun/sunvnet.c
index 55d66c9..a556eba 100644
--- a/drivers/net/ethernet/sun/sunvnet.c
+++ b/drivers/net/ethernet/sun/sunvnet.c
@@ -958,6 +958,8 @@ vnet_select_queue(struct net_device *dev, struct sk_buff *skb,
struct vnet *vp = netdev_priv(dev);
struct vnet_port *port = __tx_port_find(vp, skb);
+ if (port == NULL)
+ return 0;
return port->q_index;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] sunvnet: fix NULL pointer dereference
2014-11-12 15:58 [PATCH net-next] sunvnet: fix NULL pointer dereference David L Stevens
@ 2014-11-12 16:12 ` Sowmini Varadhan
2014-11-12 18:51 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Sowmini Varadhan @ 2014-11-12 16:12 UTC (permalink / raw)
To: David L Stevens; +Cc: David Miller, netdev
On (11/12/14 10:58), David L Stevens wrote:
> --- a/drivers/net/ethernet/sun/sunvnet.c
> +++ b/drivers/net/ethernet/sun/sunvnet.c
> @@ -958,6 +958,8 @@ vnet_select_queue(struct net_device *dev, struct sk_buff *skb,
> struct vnet *vp = netdev_priv(dev);
> struct vnet_port *port = __tx_port_find(vp, skb);
>
> + if (port == NULL)
> + return 0;
> return port->q_index;
> }
Acked-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
Thanks!
Sowmini
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] sunvnet: fix NULL pointer dereference
2014-11-12 15:58 [PATCH net-next] sunvnet: fix NULL pointer dereference David L Stevens
2014-11-12 16:12 ` Sowmini Varadhan
@ 2014-11-12 18:51 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-11-12 18:51 UTC (permalink / raw)
To: david.stevens; +Cc: netdev, sowmini.varadhan
From: David L Stevens <david.stevens@oracle.com>
Date: Wed, 12 Nov 2014 10:58:47 -0500
> This patch fixes a NULL pointer dereference when __tx_port_find() doesn't
> find a matching port.
>
> Signed-off-by: David L Stevens <david.stevens@oracle.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-12 18:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-12 15:58 [PATCH net-next] sunvnet: fix NULL pointer dereference David L Stevens
2014-11-12 16:12 ` Sowmini Varadhan
2014-11-12 18:51 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).