* [patch -next] amd-xgbe: fix ->rss_hash_type
@ 2014-11-12 8:31 Dan Carpenter
2014-11-12 15:45 ` Tom Lendacky
2014-11-12 20:04 ` David Miller
0 siblings, 2 replies; 5+ messages in thread
From: Dan Carpenter @ 2014-11-12 8:31 UTC (permalink / raw)
To: Tom Lendacky; +Cc: netdev, kernel-janitors
There was a missing break statement so we set everything to
PKT_HASH_TYPE_L3 even when we intended to use PKT_HASH_TYPE_L4.
Fixes: 5b9dfe299e55 ('amd-xgbe: Provide support for receive side scaling')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This driver has a lot of Sparse endian warnings.
http://lwn.net/Articles/205624/
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
index 7daa2cd..55ba1dc 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
@@ -1601,6 +1601,7 @@ static int xgbe_dev_read(struct xgbe_channel *channel)
case RX_DESC3_L34T_IPV6_UDP:
packet->rss_hash_type = PKT_HASH_TYPE_L4;
+ break;
default:
packet->rss_hash_type = PKT_HASH_TYPE_L3;
}
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [patch -next] amd-xgbe: fix ->rss_hash_type
2014-11-12 8:31 [patch -next] amd-xgbe: fix ->rss_hash_type Dan Carpenter
@ 2014-11-12 15:45 ` Tom Lendacky
2014-11-12 20:04 ` David Miller
1 sibling, 0 replies; 5+ messages in thread
From: Tom Lendacky @ 2014-11-12 15:45 UTC (permalink / raw)
To: Dan Carpenter; +Cc: netdev, kernel-janitors
On 11/12/2014 02:31 AM, Dan Carpenter wrote:
> There was a missing break statement so we set everything to
> PKT_HASH_TYPE_L3 even when we intended to use PKT_HASH_TYPE_L4.
>
> Fixes: 5b9dfe299e55 ('amd-xgbe: Provide support for receive side scaling')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Tom Lendacky <thomas.lendacky@amd.com>
> ---
> This driver has a lot of Sparse endian warnings.
> http://lwn.net/Articles/205624/
I'll send a patch to address the endian warnings.
Thanks,
Tom
>
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
> index 7daa2cd..55ba1dc 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
> @@ -1601,6 +1601,7 @@ static int xgbe_dev_read(struct xgbe_channel *channel)
> case RX_DESC3_L34T_IPV6_UDP:
> packet->rss_hash_type = PKT_HASH_TYPE_L4;
>
> + break;
> default:
> packet->rss_hash_type = PKT_HASH_TYPE_L3;
> }
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [patch -next] amd-xgbe: fix ->rss_hash_type
2014-11-12 8:31 [patch -next] amd-xgbe: fix ->rss_hash_type Dan Carpenter
2014-11-12 15:45 ` Tom Lendacky
@ 2014-11-12 20:04 ` David Miller
2014-11-13 6:19 ` [patch v2 " Dan Carpenter
1 sibling, 1 reply; 5+ messages in thread
From: David Miller @ 2014-11-12 20:04 UTC (permalink / raw)
To: dan.carpenter; +Cc: thomas.lendacky, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 12 Nov 2014 11:31:35 +0300
> There was a missing break statement so we set everything to
> PKT_HASH_TYPE_L3 even when we intended to use PKT_HASH_TYPE_L4.
>
> Fixes: 5b9dfe299e55 ('amd-xgbe: Provide support for receive side scaling')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> This driver has a lot of Sparse endian warnings.
> http://lwn.net/Articles/205624/
>
> diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
> index 7daa2cd..55ba1dc 100644
> --- a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
> +++ b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
> @@ -1601,6 +1601,7 @@ static int xgbe_dev_read(struct xgbe_channel *channel)
> case RX_DESC3_L34T_IPV6_UDP:
> packet->rss_hash_type = PKT_HASH_TYPE_L4;
>
> + break;
Please don't add this spurious empty line before the break;, thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread* [patch v2 -next] amd-xgbe: fix ->rss_hash_type
2014-11-12 20:04 ` David Miller
@ 2014-11-13 6:19 ` Dan Carpenter
2014-11-13 19:40 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Dan Carpenter @ 2014-11-13 6:19 UTC (permalink / raw)
To: Tom Lendacky, David Miller; +Cc: netdev, kernel-janitors
There was a missing break statement so we set everything to
PKT_HASH_TYPE_L3 even when we intended to use PKT_HASH_TYPE_L4.
Fixes: 5b9dfe299e55 ('amd-xgbe: Provide support for receive side scaling')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: remove blank line
diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
index 7daa2cd..f6014d3 100644
--- a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
+++ b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c
@@ -1600,7 +1600,7 @@ static int xgbe_dev_read(struct xgbe_channel *channel)
case RX_DESC3_L34T_IPV6_TCP:
case RX_DESC3_L34T_IPV6_UDP:
packet->rss_hash_type = PKT_HASH_TYPE_L4;
-
+ break;
default:
packet->rss_hash_type = PKT_HASH_TYPE_L3;
}
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [patch v2 -next] amd-xgbe: fix ->rss_hash_type
2014-11-13 6:19 ` [patch v2 " Dan Carpenter
@ 2014-11-13 19:40 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2014-11-13 19:40 UTC (permalink / raw)
To: dan.carpenter; +Cc: thomas.lendacky, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 13 Nov 2014 09:19:06 +0300
> There was a missing break statement so we set everything to
> PKT_HASH_TYPE_L3 even when we intended to use PKT_HASH_TYPE_L4.
>
> Fixes: 5b9dfe299e55 ('amd-xgbe: Provide support for receive side scaling')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: remove blank line
Applied, thanks a lot Dan.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-11-13 19:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-12 8:31 [patch -next] amd-xgbe: fix ->rss_hash_type Dan Carpenter
2014-11-12 15:45 ` Tom Lendacky
2014-11-12 20:04 ` David Miller
2014-11-13 6:19 ` [patch v2 " Dan Carpenter
2014-11-13 19:40 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).