From: Alexander Duyck <alexander.h.duyck@redhat.com>
To: netdev@vger.kernel.org
Cc: jeffrey.t.kirsher@intel.com
Subject: [net-next PATCH 0/4] Clean up intel driver page reuse Rx code
Date: Thu, 13 Nov 2014 08:18:12 -0800 [thread overview]
Message-ID: <20141113161148.2790.22082.stgit@ahduyck-vm-fedora20> (raw)
This patch series cleans up the page reuse and Rx path so that all of the
fixes that have been applied to any one driver are now in place for igb,
fm10k, and ixgbe. It occured to me that fm10k was missing the pfmemalloc
bits, and ixgbe was missing some logic that reduced the number of writes
needed as well as the pfmemalloc fix.
In addition ixgbe was carrying around some mostly-dead code that was
wrapping a call to writel. I removed it since it masked the fact that
ixgbe was missing the mmiowb it was supposed to have between the tail write
and the Tx queue lock release to prevent the MMIO access from racing
between CPUs.
Also one change made to all 3 drivers is that we now only overwrite 3 of
the 4 DWORDs in the Rx descriptor after allocation. The last DWORD
contains the upper 32 bits of the header address on fetch, and the length
and vlan on writeback. Since we are no longer using header split we don't
need to clear it prior to descriptor fetch as it is unused so we can save
ourselves a cycle on 32b systems by just leaving it untouched.
---
Alexander Duyck (4):
igb: Clean-up page reuse code
fm10k: Clean-up page reuse code
ixgbe: Clean-up page reuse code
ixgbe: Remove tail write abstraction and add missing barrier
drivers/net/ethernet/intel/fm10k/fm10k_main.c | 34 ++++---
drivers/net/ethernet/intel/igb/igb_main.c | 35 +++----
drivers/net/ethernet/intel/ixgbe/ixgbe.h | 5 -
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 118 ++++++++++++-------------
4 files changed, 89 insertions(+), 103 deletions(-)
--
next reply other threads:[~2014-11-13 16:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 16:18 Alexander Duyck [this message]
2014-11-13 16:18 ` [net-next PATCH 1/4] igb: Clean-up page reuse code Alexander Duyck
2014-11-13 16:18 ` [net-next PATCH 2/4] fm10k: " Alexander Duyck
2014-11-13 16:18 ` [net-next PATCH 3/4] ixgbe: " Alexander Duyck
2014-11-13 16:18 ` [net-next PATCH 4/4] ixgbe: Remove tail write abstraction and add missing barrier Alexander Duyck
2014-11-13 16:49 ` [net-next PATCH 0/4] Clean up intel driver page reuse Rx code Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141113161148.2790.22082.stgit@ahduyck-vm-fedora20 \
--to=alexander.h.duyck@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox