From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Stringer Subject: Re: [PATCHv2 net 2/2] fm10k: Implement ndo_gso_check() Date: Thu, 13 Nov 2014 16:29:16 -0800 Message-ID: <201411131629.16621.joestringer@nicira.com> References: <1415921801-10452-1-git-send-email-joestringer@nicira.com> <20141113235219.GA35957@gmail.com> <1415923959.2454.44.camel@jtkirshe-mobl> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Cc: Shannon Nelson , Jesse Brandeburg , netdev@vger.kernel.org, matthew.vick@intel.com, linux.nics@intel.com, therbert@google.com, gerlitz.or@gmail.com, alexander.duyck@gmail.com, linux-kernel@vger.kernel.org, jesse@nicira.com To: Jeff Kirsher Return-path: In-Reply-To: <1415923959.2454.44.camel@jtkirshe-mobl> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thursday, November 13, 2014 16:12:39 Jeff Kirsher wrote: > On Thu, 2014-11-13 at 15:52 -0800, Joe Stringer wrote: > > On Thu, Nov 13, 2014 at 03:41:56PM -0800, Jeff Kirsher wrote: > > > On Thu, 2014-11-13 at 15:36 -0800, Joe Stringer wrote: > > > > ndo_gso_check() was recently introduced to allow NICs to report > > > > the > > > > > > offloading support that they have on a per-skb basis. Add an > > > > implementation for this driver which checks for something that > > > > looks > > > > > > like VXLAN. > > > > > > > > Signed-off-by: Joe Stringer > > > > --- > > > > v2: Reuse fm10k_tx_encap_offload(). > > > > --- > > > > > > > > drivers/net/ethernet/intel/fm10k/fm10k.h | 1 + > > > > drivers/net/ethernet/intel/fm10k/fm10k_main.c | 2 +- > > > > drivers/net/ethernet/intel/fm10k/fm10k_netdev.c | 8 ++++++++ > > > > 3 files changed, 10 insertions(+), 1 deletion(-) > > > > > > Same with this one as well, thanks Joe. > > > > Thanks Jeff. > > > > Could you remind me, is the equivalent i40e patch on your queue or > > were > > we still waiting on further feedback from Shannon/Jesse? > > Actually, looks like I dropped the patch due to community feedback and > was expecting a v2. Was I incorrect in doing so? That's fine. There were some unresolved questions for what that version should look like, but I can repost to start the discussion again. Cheers, Joe