From: Joe Stringer <joestringer@nicira.com>
To: "Vick, Matthew" <matthew.vick@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
Linux NICS <Linux-nics@isotope.jf.intel.com>,
"therbert@google.com" <therbert@google.com>,
"gerlitz.or@gmail.com" <gerlitz.or@gmail.com>,
"alexander.duyck@gmail.com" <alexander.duyck@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCHv2 net 1/2] fm10k: Check tunnel header length in encap offload
Date: Thu, 13 Nov 2014 16:54:19 -0800 [thread overview]
Message-ID: <201411131654.19998.joestringer@nicira.com> (raw)
In-Reply-To: <D08A8E37.5FC83%matthew.vick@intel.com>
On Thursday, November 13, 2014 16:41:03 Vick, Matthew wrote:
> On 11/13/14, 3:36 PM, "Joe Stringer" <joestringer@nicira.com> wrote:
> >fm10k supports up to 184 bytes of inner+outer headers. Add an initial
> >check to fail encap offload if these are too large.
> >
> >Signed-off-by: Joe Stringer <joestringer@nicira.com>
> >---
> >Matthew, I didn't see the equivalent patch on netdev so I went ahead and
> >created it. If I've missed this somewhere, then please disregard.
> >
> >v2: First post.
>
> You didn't miss it Joe--it just hasn't made it up yet. :) It's currently
> in Jeff's tree for testing. You're on the CC for the patch, so you'll get
> a notification once it goes up. It's basically the same as what you have,
> except the #define I use is 184 and I use inner_tcp_hdrlen() to account
> for the inner TCP header length.
>
> Since your second patch should apply cleanly on top of mine, what do you
> think about dropping the first patch in this series and Jeff can send our
> two patches up together once they've passed testing?
Ah, that sounds great.
Cheers,
Joe
prev parent reply other threads:[~2014-11-14 0:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 23:36 [PATCHv2 net 1/2] fm10k: Check tunnel header length in encap offload Joe Stringer
2014-11-13 23:36 ` [PATCHv2 net 2/2] fm10k: Implement ndo_gso_check() Joe Stringer
2014-11-13 23:41 ` Jeff Kirsher
2014-11-13 23:52 ` Joe Stringer
2014-11-14 0:12 ` Jeff Kirsher
2014-11-14 0:29 ` Joe Stringer
2014-11-13 23:41 ` [PATCHv2 net 1/2] fm10k: Check tunnel header length in encap offload Jeff Kirsher
2014-11-14 0:41 ` Vick, Matthew
2014-11-14 0:54 ` Joe Stringer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201411131654.19998.joestringer@nicira.com \
--to=joestringer@nicira.com \
--cc=Linux-nics@isotope.jf.intel.com \
--cc=alexander.duyck@gmail.com \
--cc=gerlitz.or@gmail.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.vick@intel.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).